include codeworld-available-pkgs in cabal.project
#1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compilation succeeds without GHCJS
peterbecich
commented
Oct 31, 2021
| witherable, | ||
| wl-pprint-annotated, | ||
| zenc | ||
| if impl(ghcjs -any) |
There was a problem hiding this comment.
similar to
codeworld/codeworld-base/codeworld-base.cabal
Lines 41 to 65 in e596c20
peterbecich
commented
Oct 31, 2021
| wl-pprint-annotated, | ||
| zenc | ||
| else | ||
| -- excludes ghcjs-base and ghcjs-prim |
There was a problem hiding this comment.
The only difference in the else dependencies is the omission of ghcjs-base and ghcjs-prim.
peterbecich
force-pushed
the
update-cabal-project
branch
from
e7e4e64
to
bf49616
Compare
peterbecich
force-pushed
the
update-cabal-project
branch
from
bf49616
to
76bdfd5
Compare
|
What's the advantage of doing this? |
|
CI coverage, and I think it might help get Nix support working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also changes
codeworld-available-pkgs.cabalso that building succeeds without GHCJS.