Support CoseKey field ordering #85
Conversation
daviddrysdale
force-pushed
the
key-sort
branch
from
fb85c29
to
3163b30
Compare
src/common/mod.rs
Outdated
| Lexicographic, | ||
| /// Order values by encoded length, then by lexicographic ordering of encoded form, as per RFC | ||
| /// 7049 section 3.9 (Canonical CBOR). | ||
| LengthLexicographic, |
There was a problem hiding this comment.
LengthFirstLexicographic ?
src/key/tests.rs
Outdated
| struct TestCase { | ||
| key_data: &'static str, // hex | ||
| canonical_key: CoseKey, | ||
| deterministic_key: CoseKey, |
There was a problem hiding this comment.
What does "deterministic" mean here? How does it relate to "canonical"?
Maybe "old_canonical", "new_canonical"?
There was a problem hiding this comment.
RFC 7049 talks about "canonical CBOR", RFC 8949 talks about "deterministic encoding".
There was a problem hiding this comment.
Yeah, but RFC 7049 is obsoleted by RFC 8949, so both are deterministic now. (And it says "The terms are essentially interchangeable".)
We don't use the term deterministic elsewhere in the code.
There was a problem hiding this comment.
"Deterministic" isn't mentioned elsewhere in the code because CBOR/COSE spec tried quite hard to avoid it being necessary – they just missed that COSE_Key is likely to end up being signed-over in chains.
Moved to use rfcNNNN_ prefixes.
No description provided.