Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User guide: fixing typos #1087

Merged
merged 1 commit into from
Jul 1, 2022
Merged

User guide: fixing typos #1087

merged 1 commit into from
Jul 1, 2022

Conversation

deining
Copy link
Collaborator

@deining deining commented Jul 1, 2022

No description provided.

@deining deining added the user guide Improvements to user guide label Jul 1, 2022
@deining deining requested a review from chalin July 1, 2022 18:35
@LisaFC LisaFC merged commit e0a3be7 into google:main Jul 1, 2022
@deining deining removed the request for review from chalin July 2, 2022 06:45
@deining deining deleted the typo branch July 2, 2022 06:45
chalin
chalin reviewed Jul 4, 2022
View reviewed changes
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and fixing those @deining!

@chalin
Copy link
Collaborator

chalin commented Jul 4, 2022

Does either of you (@deining @LisaFC) remember if we have an issue open already for link checking? I though we had one but can't find any.

@deining
Copy link
Collaborator Author

deining commented Jul 6, 2022

Does either of you (@deining @LisaFC) remember if we have an issue open already for link checking?

Yes, we do. Please see this issue which was raised in the docsy-example project.

fekete-robert pushed a commit to fekete-robert/docsy that referenced this pull request Sep 13, 2022
@deining @fekete-robert
User guide: fixing typos (google#1087)
5f18023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin left review comments

Assignees
No one assigned
Labels
user guide Improvements to user guide
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deining @chalin @LisaFC