SVV_TABLE tests #21
Open
SVV_TABLE tests #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregflack
force-pushed
the
dev-svv-table-tests
branch
from
f8eff30 to
f6df564
Compare
gregflack
force-pushed
the
dev-svv-table-tests
branch
from
d373a42 to
e108163
Compare
dmorokov
force-pushed
the
dev-cvv-columns-test
branch
4 times, most recently
from
5661f9c to
d5e6e7e
Compare
gregflack
force-pushed
the
dev-svv-table-tests
branch
from
5b69b81 to
f92b063
Compare
dmorokov
force-pushed
the
dev-cvv-columns-test
branch
2 times, most recently
from
32e7f6e to
8738593
Compare
gregflack
requested review from
cyulysses-corp,
haselbach,
paolomorandini,
mjquinn-google and
bdw-g
as code owners
| implementation 'org.testng:testng:7.5' | ||
| implementation 'org.slf4j:slf4j-api:2.0.0-alpha5' | ||
| implementation 'org.slf4j:slf4j-jdk14:2.0.0-alpha5' | ||
| implementation 'com.amazon.redshift:redshift-jdbc42:2.1.0.7' |
There was a problem hiding this comment.
It looks to me as if this is only ever used at runtime; shouldn't this be runtimeOnly instead?
| dependencies { | ||
| implementation 'org.codehaus.groovy:groovy-all:3.0.10' | ||
| implementation 'com.google.guava:guava:31.1-jre' | ||
| implementation 'org.testng:testng:7.5' |
There was a problem hiding this comment.
Should this be testImplementation?
dmorokov
force-pushed
the
dev-cvv-columns-test
branch
from
8738593 to
4e7e799
Compare
| /** | ||
| * @return String or an empty string if null. | ||
| */ | ||
| public static String getStringNotNull(String value) { |
There was a problem hiding this comment.
nit: suggest changing the name to "getStringOrEmpty". Same for the other method named getStringNotNull.
| /** | ||
| * @return int or 0 if "". | ||
| */ | ||
| public static int getIntNotNull(String value) { |
There was a problem hiding this comment.
nit: suggest "getIntOrZeroFromString"
| * @param column Database column name. | ||
| * @return String or an empty string if null. | ||
| */ | ||
| public static String getStringNotNull(ResultSet rs, String column) throws SQLException { |
There was a problem hiding this comment.
it is inherited from Danila solition
dmorokov
force-pushed
the
dev-cvv-columns-test
branch
3 times, most recently
from
941ccdd to
42a0b6e
Compare
1. Added JdbcUtils and methods 2. Added svv_columns.sql for retrieving table's data 3. Added SvvColumnsTest test 4. Removed CsvUtil and methods 5. Added Gradle reporting plugin 6. Setting dumper-integration-tests as a root independent Gradle project 7. Added required EnvVars to build.gradle
dmorokov
force-pushed
the
dev-cvv-columns-test
branch
from
42a0b6e to
663d9db
Compare
1. Test Automation Framework skeleton 2. Gradle config with most likely deps 3. Template Test 4. Logging props 5. Base classes for testing and other utility needs 6. Code style accordingly google-formatter-plugin
1. Added JdbcUtils and methods 2. Added svv_columns.sql for retrieving table's data 3. Added SvvColumnsTest test 4. Added SvvColumnsRow POJO object 5. Added CsvUtil and methods 6. Added Gradle reporting plugin
Added svv_tables.sql for querying data Added SvvTablesTest test
gregflack
force-pushed
the
dev-svv-table-tests
branch
from
7ab6bdf to
04d5310
Compare
dmorokov
force-pushed
the
dev-cvv-columns-test
branch
from
663d9db to
03e12df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added svv_tables.sql for querying data
Added SvvTablesTest test
Added SvvTablesRow POJO object
Removed unused dependencies