Merge pull request #1929 from tst-basilhuffman/popup_jumbled_text

fix jumbled text in popups

earth_enterprise/src/fusion/fusionui/AssetBase.cpp

@@ -292,7 +292,7 @@ void AssetBase::InstallMainWidget() {
 void AssetBase::SetName(const QString& text) {
   asset_path_ = text;
   std::string pretty_name { AssetPrettyName().toStdString() };
-  std::string short_name { shortAssetName(text.toUtf8().constData()) };
+  std::string short_name { shortAssetName(text) };
 
   setCaption(QString(pretty_name.c_str()) + " : " + short_name.c_str());
   emit NameChanged(text);

earth_enterprise/src/fusion/fusionui/AssetChooser.cpp

@@ -15,15 +15,12 @@
 
 #include "fusion/fusionui/AssetChooser.h"
 
-#include <list>
-
 #include <Qt/qstring.h>
 #include <Qt/qlineedit.h>
 #include <Qt/qpushbutton.h>
 #include <Qt/qcombobox.h>
 #include <Qt/qmessagebox.h>
 #include <Qt/q3iconview.h>
-//#include <qiconview.h>
 #include <Qt/qinputdialog.h>
 #include <Qt/qapplication.h>
 #include <Qt/qcoreevent.h>
@@ -62,7 +59,7 @@ class FolderItem : public QIconViewItem {
 
 FolderItem::FolderItem(QIconView* parent, const gstAssetFolder& f)
     : QIconViewItem(parent), folder(f) {
-  setText(shortAssetName(f.name().toUtf8().constData()));
+  setText(shortAssetName(f.name()));
   AssetDisplayHelper a(AssetDefs::Invalid, std::string());
   setPixmap(a.GetPixmap());
   setKey(QString("0" + text()));
@@ -84,13 +81,8 @@ class AssetItem : public QIconViewItem {
 AssetItem::AssetItem(QIconView* parent, gstAssetHandle handle)
     : QIconViewItem(parent), assetHandle(handle) {
 
-  auto name = handle->getName().toStdString();
-  auto pos = name.rfind('.');
-  if (pos != std::string::npos)
-  {
-      name = name.substr(0,pos);
-  }
-  setText(name.c_str());
+  auto saname = shortAssetName(handle->getName());
+  setText(saname);
 
   Asset asset = handle->getAsset();
   AssetDisplayHelper a(asset->type, asset->subtype);
@@ -179,9 +171,8 @@ AssetChooser::AssetChooser(
   }
 
   // Insert compatible asset items in view filter combobox of OpenDialog.
-  for (size_t i = 0; i < compatible_asset_defs.size(); ++i) {
-    const AssetCategoryDef& asset_category_def = compatible_asset_defs[i];
-    AssetDisplayHelper adh(asset_category_def.type, asset_category_def.subtype);
+  for (const auto& i : compatible_asset_defs) {
+    AssetDisplayHelper adh(i.type, i.subtype);
     compatible_asset_types_.push_back(adh);
     filterCombo->insertItem(adh.GetPixmap(), adh.PrettyName());
   }
@@ -249,8 +240,9 @@ bool AssetChooser::matchFilter(const gstAssetHandle handle) const {
 
   if (match_string_ == all_compatible_assets_filter_text_) {
     assert(!all_compatible_assets_filter_text_.empty());
-    for (size_t i = 0; i < compatible_asset_types_.size(); ++i) {
-      if (a.PrettyName() == compatible_asset_types_[i].PrettyName())
+
+    for (const auto& i : compatible_asset_types_) {
+      if (a.PrettyName() == i.PrettyName())
         return true;
     }
     return false;
@@ -315,9 +307,8 @@ void AssetChooser::accept() {
     // here
     AssetItem* assetItem = dynamic_cast<AssetItem*>(item);
     if (assetItem != NULL) {
-        std::string temp { shortAssetName(assetItem->getAssetHandle()->getName()
-                                          .toStdString().c_str()) };
-      nameEdit->setText(temp.c_str());
+      auto saname = shortAssetName(assetItem->getAssetHandle()->getName());
+      nameEdit->setText(saname);
       gstAssetHandle asset_handle = assetItem->getAssetHandle();
       Asset asset = asset_handle->getAsset();
       type_ = asset->type;
@@ -502,9 +493,9 @@ void AssetChooser::updateView(const gstAssetFolder& folder) {
   // first add all folders
   //
   std::vector<gstAssetFolder> folders = folder.getAssetFolders();
-  for (std::vector<gstAssetFolder>::iterator it = folders.begin();
-       it != folders.end(); ++it) {
-    (void)new FolderItem(iconView, *it);
+
+  for (const auto& it : folders) {
+    (void)new FolderItem(iconView, it);
   }
 
   //

earth_enterprise/src/fusion/fusionui/AssetIconView.cpp

@@ -46,8 +46,8 @@ AssetIcon::AssetIcon(QIconView* parent, gstAssetHandle handle, int initsz)
   if (defaultImage == NULL)
     defaultImage = new QImage(uic_load_pixmap("preview_default.png").
                               convertToImage());
-
-  setText(shortAssetName(handle->getName().toUtf8().constData()));
+  auto name = shortAssetName(handle->getName());
+  setText(name);
 
   QImage img;
   AssetVersion ver(handle->getAsset()->CurrVersionRef());

earth_enterprise/src/fusion/fusionui/AssetManager.cpp

@@ -223,9 +223,9 @@ void AssetFolder::setOpen(bool o) {
 
 void AssetFolder::populate() {
   std::vector<gstAssetFolder> folders = folder.getAssetFolders();
-  std::vector<gstAssetFolder>::iterator it = folders.begin();
-  for (; it != folders.end(); ++it) {
-    (void)new AssetFolder(this, *it);
+
+  for (const auto& it : folders) {
+    (void)new AssetFolder(this, it);
   }
 }
 
@@ -267,9 +267,9 @@ static QPixmap uic_load_pixmap_AssetManager(const QString& name) {
 }
 
 bool DatabaseHasValidVersion(const Asset &asset) {
-  AssetStorage::VersionList::const_iterator version = asset->versions.begin();
-  for (; version != asset->versions.end(); ++version) {
-    AssetVersion asset_version(*version);
+
+  for (const auto& version : asset->versions) {
+    AssetVersion asset_version(version);
     if (asset_version->state != AssetDefs::Succeeded)
       continue;
     if (asset_version->subtype == kMapDatabaseSubtype) {
@@ -519,8 +519,8 @@ AssetManager::AssetManager(QWidget* parent)
   {
     gstProviderSet providers;
     if (providers.Load()) {
-      for (unsigned int i = 0; i < providers.items.size(); ++i) {
-        provider_map_[providers.items[i].id] = providers.items[i].key;
+      for (const auto& it : providers.items) {
+        provider_map_[it.id] = it.key;
       }
     }
   }
@@ -1016,7 +1016,10 @@ void AssetManager::ShowAssetMenu(const gstAssetHandle& asset_handle,
   // first item in menu should be the asset name since the table
   // might get redrawn after the menu has popped-up
   AssetDisplayHelper a(current_asset->type, current_asset->subtype);
-  menu.insertItem(a.GetPixmap(), shortAssetName(asset_handle->getName().toUtf8().constData()));
+
+  std::string shortName = shortAssetName(asset_handle->getName());
+
+  menu.insertItem(a.GetPixmap(), shortName.c_str());
 
   menu.insertSeparator();
   menu.insertSeparator();
@@ -1194,10 +1197,9 @@ void AssetManager::PushDatabase(const gstAssetHandle& handle) {
   }
 
   std::vector<QString> nicknames;
-  std::vector<ServerCombination>::const_iterator it =
-      sc_set.combinations.begin();
-  for (; it != sc_set.combinations.end(); ++it) {
-    nicknames.push_back(it->nickname);
+
+  for (const auto& it : sc_set.combinations) {
+    nicknames.push_back(it.nickname);
   }
 
   PushDatabaseDialog push_db_dlg(this, asset, nicknames);
@@ -1235,14 +1237,14 @@ void AssetManager::PushDatabase(const gstAssetHandle& handle) {
   // Update the preferences with the user's choice. We want to remember these
   // choices so that we can automatically select this server next time they
   // push/publish.
-  std::string database_name = shortAssetName(asset->GetRef().toString().c_str());
+  std::string database_name = shortAssetName(asset->GetRef().toString());
   Preferences::UpdatePublishServerDbMap(database_name, nickname.toUtf8().constData());
 
   ServerConfig stream_server, search_server;
-  for (it = sc_set.combinations.begin();
-       it != sc_set.combinations.end(); ++it) {
-    if (nickname == it->nickname) {
-      stream_server = it->stream;
+
+  for (const auto& it : sc_set.combinations) {
+    if (nickname == it.nickname) {
+      stream_server = it.stream;
       search_server = stream_server;
       break;
     }
@@ -1327,10 +1329,9 @@ void AssetManager::PublishDatabase(const gstAssetHandle& handle) {
   }
 
   std::vector<QString> nicknames;
-  std::vector<ServerCombination>::const_iterator it =
-      sc_set.combinations.begin();
-  for (; it != sc_set.combinations.end(); ++it) {
-    nicknames.push_back(it->nickname);
+
+  for (const auto& it : sc_set.combinations) {
+    nicknames.push_back(it.nickname);
   }
 
 
@@ -1370,14 +1371,14 @@ void AssetManager::PublishDatabase(const gstAssetHandle& handle) {
   // Update the preferences with the user's choice. We want to remember these
   // choices so that we can automatically select this server next time they
   // push/publish.
-  std::string database_name = shortAssetName(asset->GetRef().toString().c_str());
+  std::string database_name = shortAssetName(asset->GetRef().toString());
   Preferences::UpdatePublishServerDbMap(database_name, nickname.toUtf8().constData());
 
   ServerConfig stream_server, search_server;
-  for (it = sc_set.combinations.begin();
-       it != sc_set.combinations.end(); ++it) {
-    if (nickname == it->nickname) {
-      stream_server = it->stream;
+
+  for (const auto& it : sc_set.combinations) {
+    if (nickname == it.nickname) {
+      stream_server = it.stream;
       search_server = stream_server;
       break;
     }
@@ -1621,10 +1622,10 @@ void AssetManager::assetsChanged(const AssetChanges& changes) {
 
   // check to see if any of the changes are in this directory
   std::set<std::string> changedHere;
-  for (AssetChanges::CIterator i = changes.items.begin();
-       i != changes.items.end(); ++i) {
-    if (khDirname(i->ref) == curr) {
-      changedHere.insert(AssetVersionRef(i->ref).AssetRef());
+
+  for(const auto& i : changes.items) {
+    if (khDirname(i.ref) == curr) {
+      changedHere.insert(AssetVersionRef(i.ref).AssetRef());
     }
   }
 
@@ -1810,7 +1811,7 @@ void AssetManager::UpdateTableItem(int row, gstAssetHandle handle,
     int bpos = aname.rfind('/') + 1, epos = aname.rfind('.');
     aname = aname.substr(bpos,epos-bpos);
 
-    if (aname != std::string(assetTableView->GetItem(i)->text().toUtf8().constData()))
+    if (aname != assetTableView->GetItem(i)->text().toStdString())
     {
         assetTableView->GetItem(i)->setText(aname.c_str());
     }

earth_enterprise/src/fusion/fusionui/AssetProperties.cpp

@@ -70,7 +70,7 @@ AssetProperties::AssetProperties( QWidget* parent, const gstAssetHandle &handle
   versionsList->setSorting( 0, false );
 
   Asset asset = handle->getAsset();
-  nameLabel->setText( shortAssetName( handle->getName().toUtf8().constData() ) );
+  nameLabel->setText( shortAssetName( handle->getName()) );
   typeLabel->setText( ToString( asset->type ).c_str() );
   subTypeLabel->setText( asset->PrettySubtype().c_str() );
 

earth_enterprise/src/fusion/fusionui/AssetTableView.cpp

@@ -45,7 +45,7 @@ AssetTableItem::AssetTableItem(QTable* table, gstAssetHandle handle)
   Asset asset = handle->getAsset();
   AssetDisplayHelper a(asset->type, asset->PrettySubtype());
   setPixmap(a.GetPixmap());
-  setText(shortAssetName(handle->getName().toUtf8().constData()));
+  setText(shortAssetName(handle->getName()));
 }
 
 AssetTableItem::~AssetTableItem() {

earth_enterprise/src/fusion/fusionui/DatabaseWidget.cpp

@@ -37,7 +37,7 @@ void DatabaseWidget::Prefill(const DatabaseEditRequest& request) {
 
   if (request.config.vectorProject.size() != 0) {
     projects.push_back(request.config.vectorProject);
-    vector_project_label->setText(shortAssetName(request.config.vectorProject.c_str()));
+    vector_project_label->setText(shortAssetName(request.config.vectorProject));
   } else {
     vector_project_label->setText(empty_text);
   }
@@ -49,14 +49,14 @@ void DatabaseWidget::Prefill(const DatabaseEditRequest& request) {
   } else {
     if (request.config.imageryProject.size() != 0) {
       projects.push_back(request.config.imageryProject);
-      imagery_project_label->setText(shortAssetName(request.config.imageryProject.c_str()));
+      imagery_project_label->setText(shortAssetName(request.config.imageryProject));
     } else {
       imagery_project_label->setText(empty_text);
     }
 
     if (request.config.terrainProject.size() != 0) {
       projects.push_back(request.config.terrainProject);
-      terrain_project_label->setText(shortAssetName(request.config.terrainProject.c_str()));
+      terrain_project_label->setText(shortAssetName(request.config.terrainProject));
     } else {
       terrain_project_label->setText(empty_text);
     }
@@ -97,7 +97,7 @@ void DatabaseWidget::ChooseVectorProject() {
   if (!chooser.getFullPath(newpath))
     return;
 
-  vector_project_label->setText(shortAssetName(newpath.toUtf8().constData()));
+  vector_project_label->setText(shortAssetName(newpath));
 }
 
 void DatabaseWidget::ChooseImageryProject() {
@@ -110,7 +110,7 @@ void DatabaseWidget::ChooseImageryProject() {
   if (!chooser.getFullPath(newpath))
     return;
 
-  imagery_project_label->setText(shortAssetName(newpath.toUtf8().constData()));
+  imagery_project_label->setText(shortAssetName(newpath));
 }
 
 void DatabaseWidget::ChooseTerrainProject() {
@@ -123,7 +123,7 @@ void DatabaseWidget::ChooseTerrainProject() {
   if (!chooser.getFullPath(newpath))
     return;
 
-  terrain_project_label->setText(shortAssetName(newpath.toUtf8().constData()));
+  terrain_project_label->setText(shortAssetName(newpath));
 }
 
 void DatabaseWidget::ClearVectorProject() {

earth_enterprise/src/fusion/fusionui/LayerProperties.cpp

@@ -54,7 +54,7 @@ LayerProperties::LayerProperties(QWidget* parent, const LayerConfig& config,
   layer_config_.AssignUuidIfEmpty();
 
   uuidEdit->setText(layer_config_.asset_uuid_.c_str());
-  assetNameLabel->setText(shortAssetName(layer_config_.assetRef.c_str()));
+  assetNameLabel->setText(shortAssetName(layer_config_.assetRef));
   preserveTextSpin->setValue(layer_config_.preserveTextLevel);
   isVisibleCheck->setChecked(layer_config_.isVisible);
 

earth_enterprise/src/fusion/fusionui/MapDatabaseWidget.cpp

@@ -42,7 +42,7 @@ void MapDatabaseWidget::Prefill(const MapDatabaseEditRequest& request) {
 
   if (request.config.mapProject.size() != 0) {
     projects.push_back(request.config.mapProject);
-    map_project_label->setText(shortAssetName(request.config.mapProject.c_str()));
+    map_project_label->setText(shortAssetName(request.config.mapProject));
   } else {
     map_project_label->setText(empty_text);
   }
@@ -53,7 +53,7 @@ void MapDatabaseWidget::Prefill(const MapDatabaseEditRequest& request) {
     if (request.config.imageryProject.size() != 0) {
       projects.push_back(request.config.imageryProject);
       imagery_project_label->setText(
-          shortAssetName(request.config.imageryProject.c_str()));
+          shortAssetName(request.config.imageryProject));
     } else {
       imagery_project_label->setText(empty_text);
     }
@@ -107,7 +107,7 @@ void MapDatabaseWidget::ChooseMapProject() {
   if (!chooser.getFullPath(newpath))
     return;
 
-  map_project_label->setText(shortAssetName(newpath.toUtf8().constData()));
+  map_project_label->setText(shortAssetName(newpath));
 }
 
 void MapDatabaseWidget::ChooseImageryProject() {
@@ -120,7 +120,7 @@ void MapDatabaseWidget::ChooseImageryProject() {
   if (!chooser.getFullPath(newpath))
     return;
 
-  imagery_project_label->setText(shortAssetName(newpath.toUtf8().constData()));
+  imagery_project_label->setText(shortAssetName(newpath));
 }
 
 void MapDatabaseWidget::ClearMapProject() {

earth_enterprise/src/fusion/fusionui/MapProject.cpp

@@ -84,12 +84,12 @@ void MapLayerItem::Init() {
       setText(0, layer_item_config_.legend.GetValue().defaultLocale.name);
     }
 
-    setText(1, shortAssetName(layer_item_config_.assetRef.c_str()));
+    setText(1, shortAssetName(layer_item_config_.assetRef));
     AssetDisplayHelper a(layer_asset->type, layer_asset->subtype);
     setPixmap(1, a.GetPixmap());
   } else {
     setText(0, "<INVALID>");
-    setText(1, shortAssetName(layer_item_config_.assetRef.c_str()));
+    setText(1, shortAssetName(layer_item_config_.assetRef));
     setPixmap(1, AssetDisplayHelper::Pixmap(AssetDisplayHelper::Key_Unknown));
   }
 }