Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: remove package attributes for AndroidManifest.xml #7200

Conversation

suzp1984
Copy link
Contributor

Fix warning and Recommendation when ./build.sh -p android -i release

> Task :filament-android:processReleaseManifest
package="com.google.android.filament" found in source AndroidManifest.xml: /Users/jacobsu/hack/graphics/filament/android/filament-android/src/main/AndroidManifest.xml.
Setting the namespace via the package attribute in the source AndroidManifest.xml is no longer supported, and the value is ignored.
Recommendation: remove package="com.google.android.filament" from the source AndroidManifest.xml: /Users/jacobsu/hack/graphics/filament/android/filament-android/src/main/AndroidManifest.xml.

> Task :filament-utils-android:processReleaseManifest
package="com.google.android.filament.utils" found in source AndroidManifest.xml: /Users/jacobsu/hack/graphics/filament/android/filament-utils-android/src/main/AndroidManifest.xml.
Setting the namespace via the package attribute in the source AndroidManifest.xml is no longer supported, and the value is ignored.
Recommendation: remove package="com.google.android.filament.utils" from the source AndroidManifest.xml: /Users/jacobsu/hack/graphics/filament/android/filament-utils-android/src/main/AndroidManifest.xml.

The Android package name is configured in android/filament-utils-android/build.gradle & android/filamat-android/build.gradle's android.namespace property, no-longer inside the AndroidManifest.xml.

Setting the namespace via the package attribute in the source
AndroidManifest.xml is no longer supported, and the value is
ignored.
@romainguy
Copy link
Collaborator

Unfortunately this is not something we can/want to fix right now for reasons internal to Google.

@romainguy romainguy closed this Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants