Fix If the width of the image is not a multiple of 4, the rendering r… #8312
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| @@ -246,7 +246,7 @@ static void loadImage(App& app, Engine* engine, const Path& filename) { | |||
| .height(h) | |||
| .levels(0xff) | |||
| .format(channels == 3 ? | |||
| Texture::InternalFormat::RGB16F : Texture::InternalFormat::RGBA16F) | |||
| Texture::InternalFormat::RGB16F : Texture::InternalFormat::RGBA32F) | |||
There was a problem hiding this comment.
I don't understand this change. It seems like this might be an issue with a particular backend? Why is RGBA16F not working?
There was a problem hiding this comment.
Definitely seems like a backend issue. Actually I would expect RGB16F to be the issue, not RGBA16F.
…esult by image_view will be skewed. (google#8166)
|
let's hold off on this one. This is due to a bug in the vk backend, but said bug is not simple to address. |
Fix If the width of the image is not a multiple of 4, the rendering result by image_view will be skewed. (#8166)