Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Initialize model architecture to
gemma_config.Architecture.GEMMA_1
Motivation
The code in the notebook when run natively throw this error:
which is caused by the code in model.py not recognizing
Architecture.GEMMA_1
asgemma_config.Architecture.GEMMA_1
Architecture.GEMMA_1
's definition and how it is the default value of the class can be seen inconfig.py
:Type of change
Bug fix
Checklist
git pull --rebase upstream main
).