generate-gnostic: fix dropped errors (#415)

google · Dec 20, 2023 · f702249 · f702249
1 parent da1adca
commit f702249
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/generate-gnostic/generate-extension.go b/generate-gnostic/generate-extension.go
@@ -281,6 +281,9 @@ func generateExtension(schemaFile string, outDir string) error {
 		return err
 	}
 	err = exec.Command(runtime.GOROOT()+"/bin/gofmt", "-w", goFilename).Run()
+	if err != nil {
+		return err
+	}
 
 	// generate the main file.
 

diff --git a/generate-gnostic/generate-extension_test.go b/generate-gnostic/generate-extension_test.go
@@ -16,6 +16,9 @@ func TestErrorExtensionGeneratorUnsupportedPrimitive(t *testing.T) {
 		"test/x-unsupportedprimitives.json",
 		"--out_dir=/tmp",
 	).Output()
+	if err != nil {
+		t.Fatalf("error executing generate-gnostic: %v", err)
+	}
 
 	outputFile := "x-unsupportedprimitives.errors"
 	_ = ioutil.WriteFile(outputFile, output, 0644)
@@ -38,6 +41,9 @@ func TestErrorExtensionGeneratorNameCollision(t *testing.T) {
 		"test/x-extension-name-collision.json",
 		"--out_dir=/tmp",
 	).Output()
+	if err != nil {
+		t.Fatalf("error executing generate-gnostic: %v", err)
+	}
 
 	outputFile := "x-extension-name-collision.errors"
 	_ = ioutil.WriteFile(outputFile, output, 0644)