Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GetAutomatedSecurityFixes to report status #2842

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Add GetAutomatedSecurityFixes to report status #2842

merged 2 commits into from
Aug 15, 2023

Conversation

grahamhar
Copy link
Contributor

This is an attempt to fix #2080. It is also required by upstream projects such as terraform-provider-github, see issue 1301

go test github.com/google/go-github/...
ok      github.com/google/go-github/v53/github  1.165s
?       github.com/google/go-github/v53/test/fields     [no test files]
?       github.com/google/go-github/v53/test/integration        [no test files]

@grahamhar grahamhar mentioned this pull request Jul 25, 2023
Closed
@codecov
Copy link

codecov bot commented Jul 25, 2023 •
edited
Loading

Codecov Report

Merging #2842 (bef6076) into master (4074b7c) will increase coverage by 0.00%.
Report is 14 commits behind head on master.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2842   +/-   ##
=======================================
  Coverage   98.06%   98.07%           
=======================================
  Files         138      139    +1     
  Lines       12314    12357   +43     
=======================================
+ Hits        12076    12119   +43     
  Misses        162      162           
  Partials       76       76
Files Changed Coverage Δ
github/github.go 97.97% <ø> (+<0.01%) ⬆️
github/repos.go 98.86% <100.00%> (+0.01%) ⬆️

... and 8 files with indirect coverage changes

gmlewis
gmlewis approved these changes Jul 26, 2023
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @grahamhar !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Jul 26, 2023
@gmlewis gmlewis mentioned this pull request Jul 27, 2023
Merged
vandanrohatgi
vandanrohatgi reviewed Aug 15, 2023
View reviewed changes
github/repos.go Outdated
return nil, nil, err
}

// TODO: remove custom Accept header when this API fully launches
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like API docs now recommend using the common application/vnd.github+json header. Maybe we can remove this custom header?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to do that as part of this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made the changes I think are needed please let me know if I need to do anything else.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @grahamhar !

vandanrohatgi
vandanrohatgi approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@vandanrohatgi vandanrohatgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Aug 15, 2023
@gmlewis
Copy link
Collaborator

gmlewis commented Aug 15, 2023

Thank you, @vandanrohatgi !
Merging.

@gmlewis gmlewis merged commit 352e4c8 into google:master Aug 15, 2023
9 checks passed
@gmlewis gmlewis mentioned this pull request Aug 16, 2023
Merged
@grahamhar grahamhar deleted the issue-2080 branch August 19, 2023 17:45
gmlewis pushed a commit to gmlewis/go-github that referenced this pull request Sep 19, 2023
@grahamhar @gmlewis
Add GetAutomatedSecurityFixes to report status (google#2842)
7b8873f 
Fixes: google#2080.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vandanrohatgi vandanrohatgi vandanrohatgi approved these changes

@gmlewis gmlewis gmlewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Check if automated security fixes are enabled for a repository
3 participants
@grahamhar @gmlewis @vandanrohatgi