Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SubmoduleGitURL to RepositoryContent #2880

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Aug 16, 2023

Fixes: #2877.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Aug 16, 2023
@gmlewis
Copy link
Collaborator Author

gmlewis commented Aug 16, 2023

@Parker77 - do you have time for another review, please?

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #2880 (641ad3e) into master (0c562f6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2880   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files         140      140           
  Lines       12269    12269           
=======================================
  Hits        12031    12031           
  Misses        162      162           
  Partials       76       76           
Files Changed Coverage Δ
github/repos_contents.go 87.82% <ø> (ø)

Copy link

@Parker77 Parker77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Aug 16, 2023
@gmlewis
Copy link
Collaborator Author

gmlewis commented Aug 16, 2023

Thank you, @Parker77 !
Merging.

@gmlewis gmlewis merged commit e94b955 into google:master Aug 16, 2023
9 checks passed
@gmlewis gmlewis deleted the chore/i2877-add-submodule-git-url branch August 16, 2023 17:53
gmlewis added a commit to gmlewis/go-github that referenced this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancing RepositoryContent Struct for SubmoduleGitURL support in github/repos_contents.go
2 participants