Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serialization of repository_names conditions object #2910

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

ysoldak
Copy link
Contributor

@ysoldak ysoldak commented Sep 4, 2023

RulesetRepositoryNamesConditionParameters, Include and Exclude fields shall not be omitted when empty.

Fixes: #2909

RulesetRepositoryNamesConditionParameters
Include and Exclude shall not be omitted
@ysoldak ysoldak changed the title Fix json serialisation for RepositoryName fields Fix json serialisation of repository_names conditions object Sep 4, 2023
@ysoldak ysoldak changed the title Fix json serialisation of repository_names conditions object Fix serialisation of repository_names conditions object Sep 4, 2023
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #2910 (2852e78) into master (5ab57e7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2910   +/-   ##
=======================================
  Coverage   98.12%   98.12%           
=======================================
  Files         142      142           
  Lines       12453    12453           
=======================================
  Hits        12219    12219           
  Misses        159      159           
  Partials       75       75           
Files Changed Coverage Δ
github/repos_rules.go 100.00% <ø> (ø)

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ysoldak !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis
Copy link
Collaborator

gmlewis commented Sep 4, 2023

Thank you, @WillAbides !
Merging.

@gmlewis gmlewis changed the title Fix serialisation of repository_names conditions object Fix serialization of repository_names conditions object Sep 4, 2023
@gmlewis gmlewis merged commit 1a6e6fe into google:master Sep 4, 2023
9 checks passed
gmlewis pushed a commit to gmlewis/go-github that referenced this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to create Repo Ruleset if RepositoryName fields are empty
3 participants