Add Webhook for Repository ruleset

[unamdev0]

Added Repository ruleset event
Fixes #3295

[unamdev0]

@gmlewis please ignore the previous PR and review this. This PR contains just my code and hasn't been reabased with master branch.
updated RuleSet to Ruleset everywhere, also improved the comment describing the repository ruleset event

[gmlewis]

I'm going to hold off reviewing this one until comments from the last PR are addressed.
Specifically,

Godocs should always use complete sentences with punctuation so that the auto-generated package documentation formats and reads nicely.

It looks like GitHub ate my other lengthy comment, unfortunately... but the gist of it was that every exported struct needs a Godoc-style comment to explain its purpose and usage for the auto-generated package documentation.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.39%. Comparing base (2b8c7fa) to head (e125889).
Report is 154 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3305      +/-   ##
==========================================
- Coverage   97.72%   93.39%   -4.33%     
==========================================
  Files         153      172      +19     
  Lines       13390    11909    -1481     
==========================================
- Hits        13085    11123    -1962     
- Misses        215      692     +477     
- Partials       90       94       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[unamdev0]

I'm going to hold off reviewing this one until comments from the last PR are addressed.
Specifically,

Godocs should always use complete sentences with punctuation so that the auto-generated package documentation formats and reads nicely.

It looks like GitHub ate my other lengthy comment, unfortunately... but the gist of it was that every exported struct needs a Godoc-style comment to explain its purpose and usage for the auto-generated package documentation.

Got it, will add comments for every new struct added and will let you know

[unamdev0]

@gmlewis please go ahead and review the code, I've added comments for all the new structs generated

[gmlewis]

Thank you, @unamdev0 !
Just a few linter errors to clean up, please, and a few tweaks, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

[unamdev0]

Done @gmlewis, all the suggestion made have been added and test files have been modified accordingly

[gmlewis]

It looks like there are a few more linter errors - you can see them in the GitHub user interface, I believe.

[gmlewis]

You should also be able to see them locally if you follow step 4 of CONTRIBUTING.md.

[unamdev0]

Hi @gmlewis, I'm not able to see any linting issues shown in github interface, when running script/lint.sh. Other than that,I've made the change that was missed last time

[gmlewis]

Ah, to see them locally you probably need to merge the latest master into your PR... but I'll rerun the workflows and see if I can take screenshots for you.

[gmlewis]

@unamdev0 - can you see this?
https://github.com/google/go-github/actions/runs/11330493244/job/31508792189?pr=3305

[gmlewis]

I've gone ahead and made suggestions that should clear up the linter errors.

[unamdev0]

@gmlewis added the suggestions, should I add the changes in generated files manually as well as shown in the github UI?

[gmlewis]

@gmlewis added the suggestions, should I add the changes in generated files manually as well as shown in the github UI?

No, you should never edit the auto-generated files. If you find problems in them (which I don't think there are any), then the code that generates them gen-*.go should be modified... but usually, users of this repo can leave maintenance of those up to the maintainers of the repo. Is that what you were asking?

[gmlewis]

Can you please push those changes to the suggested changes? I'm not seeing them yet.

[unamdev0]

No, you should never edit the auto-generated files. If you find problems in them (which I don't think there are any), then the code that generates them gen-*.go should be modified... but usually, users of this repo can leave maintenance of those up to the maintainers of the repo. Is that what you were asking?

Oh okay, I've pushed changes with period at the end of comments, and not modified any other file, can you please review once

[gmlewis]

I'll go ahead and apply these as well.

[gmlewis]

Bummer. I didn't get the spacing right. working on it...

[gmlewis]

@unamdev0 - sorry for all the noise - I was trying to make it so that we wouldn't require more changes from you, but alas I was unsuccessful.

Could you please do this for me again?

git checkout feature/add-repositoryrulesetevent
git pull origin feature/add-repositoryrulesetevent
go generate ./...
git commit -am 'Run latest go generate'
git push origin feature/add-repositoryrulesetevent

[unamdev0]

done @gmlewis

[gmlewis]

Unit tests still failing. I'll see if I can fix them.

[gmlewis]

Merging.