Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Add name query parameter to ActionsService.ListArtifacts #3330

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Oct 21, 2024

Fixes: #3328.

BREAKING CHANGE: opts argument to ActionsService.ListArtifacts changed from ListOptions to ListArtifactsOptions.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.01%. Comparing base (2b8c7fa) to head (76e7f96).
Report is 157 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3330      +/-   ##
==========================================
- Coverage   97.72%   93.01%   -4.71%     
==========================================
  Files         153      172      +19     
  Lines       13390    14848    +1458     
==========================================
+ Hits        13085    13811     +726     
- Misses        215      944     +729     
- Partials       90       93       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewis
Copy link
Collaborator Author

gmlewis commented Oct 21, 2024

@muhardanz - can you please take a look at this (and possibly try it out) to see if it fixes the issue you were having?

@muhardanz
Copy link

@gmlewis I can confirm that this fixes the ListArtifacts function so that it can take in the name query string. I can also confirm that it returns the correct result

@gmlewis
Copy link
Collaborator Author

gmlewis commented Oct 21, 2024

Thank you, @muhardanz !
Merging.

@gmlewis gmlewis merged commit cc9a0ed into google:master Oct 21, 2024
6 of 7 checks passed
@gmlewis gmlewis deleted the i3328-add-name-query-param branch October 21, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to filter artifacts by name in golang
2 participants