Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fix drive cmdline-sample #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ihommani
Copy link

Adapt sample following the dependencies update

Adapt sample following the dependencies update
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@ihommani
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@ihommani
Copy link
Author

ihommani commented Jan 31, 2018

@kevinthecheung, @rmistry, @mattwhisenhunt how can we proceed to review the pull request?

@goxr3plus
Copy link

@ihommani Thank you very much for this pull request , just in time i needed it 🥇

@devrj8
Copy link

devrj8 commented Aug 8, 2018

@ihommani Thanks for fixing the issue.

Copy link

@devrj8 devrj8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the changes, It is working. I'm approving these changes.

@JamesHesterJr
Copy link

Why aren't these merged?

@MeridianFive
Copy link

These really should be merged. Spent 6 hours thinking something was wrong with outdated dependencies/imports until I realized this pull was sitting here.

@goxr3plus
Copy link

Merge it brrrrrroooooossssssss

@grant
Copy link

grant commented Jul 1, 2019

@kurtisvg Can you merge this PR?

@kurtisvg kurtisvg requested a review from neozwu July 1, 2019 18:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants