-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data collection] Prompt user to select "Drop pin" or "Draw/walk perimeter" when organizers allow it #2715
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @anandwana001 Is this ready for review? Please update the PR description to something more descriptive - "Prompt user to do what?"
Please also provide a video or screenshot once ready.
ground/src/main/java/com/google/android/ground/ui/datacollection/tasks/draw/ChoiceMap.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # ground/src/main/res/values/strings.xml
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2715 +/- ##
============================================
- Coverage 60.58% 60.23% -0.36%
Complexity 1162 1162
============================================
Files 265 266 +1
Lines 6221 6261 +40
Branches 878 892 +14
============================================
+ Hits 3769 3771 +2
- Misses 1950 1987 +37
- Partials 502 503 +1
|
Hi @anandwana001 What is the status of this PR? Has it been abandoned? |
@anandwana001 I see this is allocated for the next Iteration which starts tomorrow, leaving this open for now. |
Fixes #2469
@... PTAL?