Cleanup remaining usages of getDetailsText() from TaskData

[shobhitagarwal1612]

Fixes #1733

getDetailsText() was previously used for displaying value of response for the current task fragment. This method is extended by all response model classes (TaskData). All text should be created on view layer and not is model due to i18n.

In this PR, I've migrated all remaining usages of getDetailsText() with appropriate values and cleaned up all unused methods.

This is a pure refactor and doesn't change any existing user behavior.
Verified that this doesn't introduce any regressions via unit tests and manually running the app in an emulator.

@gino-m PTAL?

[codecov]

Codecov Report

Attention: Patch coverage is 87.50000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 62.25%. Comparing base (cdc6847) to head (ce8abd7).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
...m/google/android/ground/ui/map/gms/ConverterExt.kt	0.00%	0 Missing and 2 partials ⚠️
.../firebase/schema/CaptureLocationResultConverter.kt	0.00%	1 Missing ⚠️
...ion/tasks/location/CaptureLocationTaskViewModel.kt	88.88%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #2950      +/-   ##
============================================
+ Coverage     61.90%   62.25%   +0.35%     
+ Complexity     1204     1200       -4     
============================================
  Files           268      265       -3     
  Lines          6441     6419      -22     
  Branches        897      890       -7     
============================================
+ Hits           3987     3996       +9     
+ Misses         1898     1867      -31     
  Partials        556      556              

Files with missing lines	Coverage Δ
...ndroid/ground/model/mutation/SubmissionMutation.kt	94.44% <ø> (+4.97%)	⬆️
...ground/model/submission/CaptureLocationTaskData.kt	100.00% <ø> (+50.00%)	⬆️
...ndroid/ground/model/submission/DateTimeTaskData.kt	33.33% <ø> (+4.76%)	⬆️
...ndroid/ground/model/submission/GeometryTaskData.kt	100.00% <100.00%> (+88.88%)	⬆️
.../ground/model/submission/MultipleChoiceTaskData.kt	76.92% <100.00%> (+12.40%)	⬆️
.../android/ground/model/submission/NumberTaskData.kt	28.57% <100.00%> (-8.93%)	⬇️
...e/android/ground/model/submission/PhotoTaskData.kt	20.00% <ø> (+3.33%)	⬆️
...android/ground/model/submission/SkippedTaskData.kt	50.00% <ø> (+10.00%)	⬆️
...google/android/ground/model/submission/TaskData.kt	100.00% <ø> (ø)
...le/android/ground/model/submission/TextTaskData.kt	16.66% <ø> (-20.84%)	⬇️
... and 10 more

... and 3 files with indirect coverage changes

[gino-m]

Ah, finally!!! I've dreamt of this moment for 2+ years 😆

Would it be possible to add tests to the ViewModelTests to check this presentation logic while you're at it?

[shobhitagarwal1612]

Would it be possible to add tests to the ViewModelTests to check this presentation logic while you're at it?

Done. PTAL?

[gino-m]

LGTM, just a few more nits. Thanks!

[gino-m]

🥳