-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix activeNetworkInfo Deprecation #2968
Fix activeNetworkInfo Deprecation #2968
Conversation
Can you please add details on how you verified that no regressions are introduced with this change? |
Manul testing, should we create a separate ticket for unit test network manager class? |
Some tests are failing, can you please look into it? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2968 +/- ##
============================================
+ Coverage 63.53% 63.55% +0.02%
Complexity 1242 1242
============================================
Files 267 267
Lines 6502 6506 +4
Branches 911 911
============================================
+ Hits 4131 4135 +4
Misses 1785 1785
Partials 586 586
|
Fixes #2967
Parent Ticket #2338
This PR fixes the
activeNetworkInfo
deprecation by usingactiveNetwork
@shobhitagarwal1612 PTAL?