Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix activeNetworkInfo Deprecation #2968

Merged
merged 7 commits into from
Jan 8, 2025

Conversation

anandwana001
Copy link
Collaborator

Fixes #2967

Parent Ticket #2338

This PR fixes the activeNetworkInfo deprecation by using activeNetwork

@shobhitagarwal1612 PTAL?

@auto-assign auto-assign bot requested a review from scolsen January 2, 2025 09:29
@shobhitagarwal1612
Copy link
Member

Can you please add details on how you verified that no regressions are introduced with this change?

@anandwana001
Copy link
Collaborator Author

Can you please add details on how you verified that no regressions are introduced with this change?

Manul testing, should we create a separate ticket for unit test network manager class?

@shobhitagarwal1612
Copy link
Member

Some tests are failing, can you please look into it?

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.55%. Comparing base (0280bf5) to head (be8d16f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...com/google/android/ground/system/NetworkManager.kt 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2968      +/-   ##
============================================
+ Coverage     63.53%   63.55%   +0.02%     
  Complexity     1242     1242              
============================================
  Files           267      267              
  Lines          6502     6506       +4     
  Branches        911      911              
============================================
+ Hits           4131     4135       +4     
  Misses         1785     1785              
  Partials        586      586              
Files with missing lines Coverage Δ
...com/google/android/ground/system/NetworkManager.kt 52.00% <85.71%> (+9.14%) ⬆️

@anandwana001 anandwana001 merged commit e093874 into master Jan 8, 2025
5 checks passed
@anandwana001 anandwana001 deleted the anandwana001/2967/network-access-deprecate branch January 8, 2025 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

activeNetworkInfo is Deprecated
2 participants