Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated LocationRequest fixed with new Builder Design Pattern #2970

Merged

Conversation

anandwana001
Copy link
Collaborator

Fixes #2969

Parent Ticket #2338

LocationRequest is deprecated and update with the latest builder design pattern.

@shobhitagarwal1612 PTAL?

@auto-assign auto-assign bot requested a review from scolsen January 2, 2025 09:39
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.25%. Comparing base (3001619) to head (f2cd47f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2970      +/-   ##
============================================
- Coverage     62.25%   62.25%   -0.01%     
  Complexity     1202     1202              
============================================
  Files           265      265              
  Lines          6420     6419       -1     
  Branches        890      890              
============================================
- Hits           3997     3996       -1     
  Misses         1867     1867              
  Partials        556      556              
Files with missing lines Coverage Δ
...om/google/android/ground/system/LocationManager.kt 100.00% <100.00%> (ø)

@shobhitagarwal1612 shobhitagarwal1612 merged commit bc65fe4 into master Jan 2, 2025
5 checks passed
@shobhitagarwal1612 shobhitagarwal1612 deleted the anandwana001/2969/location-request-deprecated branch January 2, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LocationRequest is deprecated
2 participants