ViewModelProviders is updated with ViewModelProvider #2974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have we tested for regressions? Can you please specify all the edge cases tested? |
Did a manual testing for screens which are using this factory class. |
|
Can you please resolve the build failures before I take a pass? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2974 +/- ##
=========================================
Coverage 63.55% 63.55%
Complexity 1242 1242
=========================================
Files 267 267
Lines 6506 6506
Branches 911 911
=========================================
Hits 4135 4135
Misses 1785 1785
Partials 586 586 |
shobhitagarwal1612
requested changes
Jan 6, 2025
ground/src/main/java/com/google/android/ground/ui/common/ViewModelFactory.kt
Outdated
Show resolved
Hide resolved
shobhitagarwal1612
approved these changes
Jan 8, 2025
shobhitagarwal1612
deleted the
anandwana001/2973/viewmodelproviders-deprecated
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2973
Parent Ticket #2338
ViewModelProvidersis deprecated and updated with ViewModelProvider.@shobhitagarwal1612 PTAL?