Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce TaskDataHandler #2995

Merged
merged 10 commits into from
Jan 14, 2025
Merged

Conversation

shobhitagarwal1612
Copy link
Member

Towards #2993

Introduces a wrapper class for handling task data values. Provides a way to subscribe for changes to the task value.

This is a no-op change. This will be integrated along with TaskSequenceHandler in DataCollectionViewModel in future CLs.

See #2993 (comment) for detailed description.

@scolsen @anandwana001 PTAL?

@auto-assign auto-assign bot requested a review from anandwana001 January 9, 2025 16:04
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.50%. Comparing base (5d2e5ec) to head (7923270).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2995      +/-   ##
============================================
+ Coverage     63.41%   63.50%   +0.08%     
- Complexity     1244     1254      +10     
============================================
  Files           267      268       +1     
  Lines          6513     6529      +16     
  Branches        913      915       +2     
============================================
+ Hits           4130     4146      +16     
  Misses         1796     1796              
  Partials        587      587              
Files with missing lines Coverage Δ
...ndroid/ground/ui/datacollection/TaskDataHandler.kt 100.00% <100.00%> (ø)

@shobhitagarwal1612 shobhitagarwal1612 requested review from scolsen and removed request for anandwana001 January 10, 2025 01:26
@shobhitagarwal1612
Copy link
Member Author

@anandwana001 @scolsen PTAL?

@shobhitagarwal1612 shobhitagarwal1612 merged commit 47608b9 into master Jan 14, 2025
5 checks passed
@shobhitagarwal1612 shobhitagarwal1612 deleted the ashobhit/2993/task-data-handler branch January 14, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants