-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce TaskDataHandler #2995
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2995 +/- ##
============================================
+ Coverage 63.41% 63.50% +0.08%
- Complexity 1244 1254 +10
============================================
Files 267 268 +1
Lines 6513 6529 +16
Branches 913 915 +2
============================================
+ Hits 4130 4146 +16
Misses 1796 1796
Partials 587 587
|
shobhitagarwal1612
requested review from
scolsen
and removed request for
anandwana001
January 10, 2025 01:26
@anandwana001 @scolsen PTAL? |
anandwana001
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #2993
Introduces a wrapper class for handling task data values. Provides a way to subscribe for changes to the task value.
This is a no-op change. This will be integrated along with TaskSequenceHandler in DataCollectionViewModel in future CLs.
See #2993 (comment) for detailed description.
@scolsen @anandwana001 PTAL?