Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syncing recent changes. #1042

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Syncing recent changes. #1042

merged 1 commit into from
Oct 23, 2023

Conversation

mbushkov
Copy link
Collaborator

  • devenv fixes and cleanups. Support for background processes added.
  • Dummy client action and flow added as a demo.
  • EficheckCollectHashes, EficheckDumpImage client actions removed.
  • Uninstall client action removed.
  • SendFile client action removed.
  • Refactoring the Interrogate flow to not rely on Forensic Artifacts "provides" section.
  • Removed "checks" functionality.
  • Removed a number of artifact parsers (eventual goal is to remove all of them).
  • In GRR Fleetspeak Frontend - optimised message processing to handle spikes of messages from the same client.
  • Deprecated no-op "keep_client_alive" attribute in ApiCreateClientApprovalArgs.
  • Deprecated ListClientActionRequests API call (was no-op after Fleetspeak migration).
  • Removed KeepAlive, FingerprintFile, FindFiles, SendFile, Uninstall, UpdateClient, CollectEfiHashes, DumpEfiImage flows.
  • Added GetCrowdStrikeAgentID flow.
  • Deprecated GetFile flow in favor of MultiGetFile.
  • Made FileFinder an alias to ClientFileFinder, using ClientFileFinder by default everywhere. Legacy FileFinder is still available as LegacyFileFinder. Fixed several inconsistencies in ClientFileFinder client action. Same for RegistryFinder.
  • Added StatMultipleFiles and HashMultipleFiles flows to be used in UIv2.
  • Collecting more detailed stats about flow errors.
  • Newly interrogated hunts now pick up active hunts automatically.
  • UI work: hunts table, Stat/Hash multiple files flows, hunt graphs.

@mbushkov
Syncing recent changes.
a903d33 
* devenv fixes and cleanups. Support for background processes added.
* Dummy client action and flow added as a demo.
* EficheckCollectHashes, EficheckDumpImage client actions removed.
* Uninstall client action removed.
* SendFile client action removed.
* Refactoring the Interrogate flow to not rely on Forensic Artifacts
  "provides" section.
* Removed "checks" functionality.
* Removed a number of artifact parsers (eventual goal is to remove all
  of them).
* In GRR Fleetspeak Frontend - optimised message processing to handle
  spikes of messages from the same client.
* Deprecated no-op "keep_client_alive" attribute in
  ApiCreateClientApprovalArgs.
* Deprecated ListClientActionRequests API call (was no-op after
  Fleetspeak migration).
* Removed KeepAlive, FingerprintFile, FindFiles, SendFile, Uninstall,
  UpdateClient, CollectEfiHashes, DumpEfiImage flows.
* Added GetCrowdStrikeAgentID flow.
* Deprecated GetFile flow in favor of MultiGetFile.
* Made FileFinder an alias to ClientFileFinder, using ClientFileFinder
  by default everywhere. Legacy FileFinder is still available as
  LegacyFileFinder. Fixed several inconsistencies in ClientFileFinder
  client action. Same for RegistryFinder.
* Added StatMultipleFiles and HashMultipleFiles flows to be used in
  UIv2.
* Collecting more detailed stats about flow errors.
* Newly interrogated hunts now pick up active hunts automatically.
* UI work: hunts table, Stat/Hash multiple files flows, hunt graphs.
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 12, 2023
View reviewed changes
devenv/src/util/term.py

def strip_control_chars(buf: str) -> str:
"""Strips terminal control characters from a given string."""
return re.sub(r"\x1B(?:[@-Z\\-_]|\[[0-?]*[ -/]*[@-~])", "", buf)

Check warning

Code scanning / CodeQL

Overly permissive regular expression range Medium

Suspicious character range that is equivalent to [@A-Z].
devenv/src/util/term.py

def strip_control_chars(buf: str) -> str:
"""Strips terminal control characters from a given string."""
return re.sub(r"\x1B(?:[@-Z\\-_]|\[[0-?]*[ -/]*[@-~])", "", buf)

Check warning

Code scanning / CodeQL

Overly permissive regular expression range Medium

Suspicious character range that is equivalent to \[0-9:;<=>?\].
@mbushkov mbushkov marked this pull request as ready for review October 17, 2023 17:57
@mbushkov mbushkov merged commit 3b21080 into master Oct 23, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mbushkov