Simplify our maven-javadoc-plugin
configuration, and move both it and maven-source-plugin
to the default phase (which is package
).
#6772
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify our
maven-javadoc-plugin
configuration, and move both it andmaven-source-plugin
to the default phase (which ispackage
).I doubt that this ends up being a complete no-op in all scenarios (if only because of the phase change), but I didn't set out intending to change any behavior, and my various tests all passed:
mvn clean javadoc:jar deploy -DskipTests=true -Dmaven.deploy.skip=true
(also also a similar test withoutjavadoc:jar
, as discussed below)mvn clean deploy -Psonatype-oss-release -DskipTests -Drelease -Dmaven.deploy.skip=true
(now that it's passing after cl/572327204)mvn clean install -DskipTests
As part of this CL, I'm removing
javadoc:jar
from the command line we use for snapshots. I do this out of fear that it will someday result in "duplicated artifacts" (like cl/571437790), use the wrong configuration, or just run twice—as apparently it does in my test of the main changes from this CL:The new snapshot command appears to run Javadoc exactly once, as desired:
(While in the neighborhood, I considered also investigating a switch from
jar
tojar-no-fork
, similar to what we did formaven-source-plugin
, but I didn't bother. FWIW, I didn't notice any duplicate steps, so the switch might not buy us anything for Guava in particular.)Also, I removed some mentions of
org.apache.maven.plugins
, which are redundant because that is the default.RELNOTES=n/a