Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some issue and PR templates for Guava. #6785

Closed
wants to merge 0 commits into from

Conversation

copybara-service[bot]
Copy link
Contributor

Add some issue and PR templates for Guava.

RELNOTES=n/a

@copybara-service copybara-service bot force-pushed the test_573957446 branch 15 times, most recently from 09067e6 to 376a0cf Compare October 24, 2023 20:18
Copy link
Contributor

@Marcono1234 Marcono1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope it is ok that I added a few comments, and hopefully they are helpful.

(Also to clarify: I am not a member of this project so feel free to consider all of the comments only as suggestions.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this bug issue template also have a Guava version field? That might make it easier to reproduce a bug and be sure that it is fixed in case a fix has been introduced in the meantime. Or in general to notice when users report a bug for an outdated Guava version.

Comment on lines 74 to 75
- Java 17

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should maybe also have "Java 21" now?



Be aware, though: most feature requests are not accepted, even if they're suggested by
a full-time Guava team member. [Feedback](http://stackoverflow.com/a/4543114/869736) from
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably use an HTTPS URL, right?

Suggested change
a full-time Guava team member. [Feedback](http://stackoverflow.com/a/4543114/869736) from
a full-time Guava team member. [Feedback](https://stackoverflow.com/a/4543114/869736) from

Also maybe the trailing /869736 should be omitted unless you want to give Louis Wasserman some free Stack Overflow badges ;)



Be aware, though: most feature requests are not accepted, even if they're suggested by
a full-time Guava team member. [Feedback](http://stackoverflow.com/a/4543114/869736) from
Copy link
Contributor

@Marcono1234 Marcono1234 Oct 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above for the Stack Overflow URL: #6785 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant