Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added weakValues() to MultimapBuilder.java #7345

Closed
wants to merge 3 commits into from
Closed

Added weakValues() to MultimapBuilder.java #7345

wants to merge 3 commits into from

Conversation

Ayush-Thakur-geek
Copy link

@Ayush-Thakur-geek Ayush-Thakur-geek commented Aug 3, 2024

Fixes for issue id #6985

Copy link

google-cla bot commented Aug 3, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Ayush-Thakur-geek Ayush-Thakur-geek changed the title For Issue #6985 Added weakValues() to MultimapBuilder.java Aug 4, 2024
@netdpb
Copy link
Member

netdpb commented Aug 12, 2024

Hi @Ayush-Thakur-geek. Thanks for your PR. A few high-level comments:

  1. We haven't yet decided to support weak values in Multimaps at all (Support for weak values in Multimap #6985), so a PR is premature at this point.
  2. Your PR appears to add a method that has no effect. The request is to add support for weak values, not simply a method called weakValues.

As I said, we would have to decide that the feature is worth the trouble to design and implement before we'd accept implementations anyway. I'll close this PR for now.

@netdpb netdpb closed this Aug 12, 2024
@netdpb netdpb self-assigned this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants