Skip to content

Commit

Permalink
Rename GSUtil subtests to match the style of other name components.
Browse files Browse the repository at this point in the history
Also remove "slicing" which is gsutil-specific jargon for multithreadedness.

Before -> After:

- `RootFS/slicing=false` -> `RootFS/SingleThreaded`
- `EmptyDir/slicing=true` -> `EmptyDir/Multithreaded`

PiperOrigin-RevId: 718428094
  • Loading branch information
EtiennePerot authored and gvisor-bot committed Jan 22, 2025
1 parent 50731e5 commit 9d0b95f
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions test/kubernetes/benchmarks/gsutil.go
Original file line number Diff line number Diff line change
Expand Up @@ -109,13 +109,13 @@ func RunGSUtil(ctx context.Context, t *testing.T, k8sCtx k8sctx.KubernetesContex
option string
}{
{
name: "slicing=false",
name: "SingleThreaded",
option: `-o "GSUtil:sliced_object_download_threshold=0"`,
},
{
// Slicing is enabled by default, so we
// don't set any extra options.
name: "slicing=true",
// Multithreaded downloading is enabled by default, so we don't set
// any extra options.
name: "MultiThreaded",
},
} {
t.Run(slicing.name, func(t *testing.T) {
Expand Down

0 comments on commit 9d0b95f

Please sign in to comment.