Skip to content

Commit

Permalink
Explicitly set browser for uncompiled test.
Browse files Browse the repository at this point in the history
This is to ensure JRE is tested with a proper browser.

CL also removes the dev browser for Wasm tests from open-source since it is pointing to the same Chrome version and we don't need that kind of coverage externally.

CL also configures the workspace to enable webdriver browsers.

PiperOrigin-RevId: 702039849
  • Loading branch information
gkdn authored and copybara-github committed Dec 2, 2024
1 parent 8a85dad commit 124b4af
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
6 changes: 6 additions & 0 deletions WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,9 @@ load_j2cl_repo_deps()

load("//build_defs:workspace.bzl", "setup_j2cl_workspace")
setup_j2cl_workspace()

# Needed to run unit tests in Chrome.
load("@io_bazel_rules_closure//closure:defs.bzl", "setup_web_test_repositories")
setup_web_test_repositories(
chromium = True,
)
4 changes: 3 additions & 1 deletion jre/javatests/j2cl_multi_test.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ def j2cl_multi_test(name, test_class, deps, enable_jvm = True, enable_j2kt_nativ
test_class = test_class,
generate_build_test = False,
runtime_deps = j2cl_deps,
browsers = [
"//build_defs/internal_do_not_use/browser:chrome-wasm-linux",
],
**kwargs
)
j2cl_test(
Expand Down Expand Up @@ -66,7 +69,6 @@ def j2cl_multi_test(name, test_class, deps, enable_jvm = True, enable_j2kt_nativ
wasm_defs = j2wasm_defines,
browsers = [
"//build_defs/internal_do_not_use/browser:chrome-wasm-linux",
"//build_defs/internal_do_not_use/browser:chrome-wasm-dev-linux",
],
**kwargs
)
Expand Down

0 comments on commit 124b4af

Please sign in to comment.