Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone tests from implementation into a legacy directory. #369

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

copybara-service[bot]
Copy link

@copybara-service copybara-service bot commented Jan 1, 2025

Clone tests from implementation into a legacy directory.

In a follow up CL all of these tests will be the only tests run on C++17 GitHub actions.

Without these tests there would be no test coverage for C++17 after the project migrates to C++20 syntax.

Also drive by cleanup of clang-tidy failures.

#42

@copybara-service copybara-service bot force-pushed the test_711214863 branch 17 times, most recently from 832eecc to 86da4fa Compare January 6, 2025 22:33
In a follow up CL all of these tests will be the only tests run on C++17 GitHub actions.

Without these tests there would be no test coverage for C++17 after the project migrates to C++20 syntax.

Also drive by cleanup of clang-tidy failures.

#42

PiperOrigin-RevId: 712664206
@copybara-service copybara-service bot merged commit 2048800 into main Jan 6, 2025
@copybara-service copybara-service bot deleted the test_711214863 branch January 6, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant