Pack discriminator only operates on types and const auto&. #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_712294962
branch
5 times, most recently
from
72e447d to
3e3dd5b
Compare
This had inconsistent behaviour across compilers, and Ubuntu + C++20 specifically breaks. A similar issue was encountered a while back when trying to support Windows, which was what motivated the "diminished" forms. PiperOrigin-RevId: 714125891
copybara-service
bot
force-pushed
the
test_712294962
branch
from
3e3dd5b to
635e151
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pack discriminator only operates on types and const auto&.
This had inconsistent behaviour across compilers, and Ubuntu + C++20 specifically breaks.
A similar issue was encountered a while back when trying to support Windows, which was what motivated the "diminished" forms.