Added Coverage Analysis for Tests of Python Package and Updated Pytest Configurations #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyammer
reviewed
Dec 20, 2024
| uv run --python ${{ matrix.python-version }} pytest tests -m "not slow" --cov=src/magika --cov-report=xml --cov-report=term | ||
|
|
||
| - name: Upload coverage report to Coveralls | ||
| if: always() |
There was a problem hiding this comment.
this if should be removed?
There was a problem hiding this comment.
The" if: always()" will ensure that the coverage report is uploaded even if one test case fails. If this is not necessary for our workflow, I can remove it
|
Thanks! Added @kralka as reviewer to double check. |
kralka
reviewed
Dec 20, 2024
| @@ -58,7 +58,15 @@ jobs: | |||
|
|
|||
| - name: Run the python tests suite | |||
| working-directory: python | |||
| run: uv run --python ${{ matrix.python-version }} pytest tests -m "not slow" | |||
| run: | | |||
| uv run --python ${{ matrix.python-version }} pytest tests -m "not slow" --cov=src/magika --cov-report=xml --cov-report=term | |||
There was a problem hiding this comment.
Is this not already covered by the change in pytest.ini?
There was a problem hiding this comment.
The configuration in pytest.ini centralizes the coverage settings, but the run command ensures the CI pipeline executes pytest correctly. However, I can remove the redundant options from the YAML file to avoid duplication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@reyammer , as per your review comment on PR #792, I have added Coverage Analysis for Tests of Python Package for issue #221 and updated pytest configurations. Kindly review the code and verify if the changes align with the requisite updates.
The following changes have been made:
Implemented coverage analysis for the Python package using pytest-cov.
Configured pytest.ini to include coverage settings.
Added coverage tracking to the CI/CD workflow.
Updated .github/workflows to upload coverage reports to Coveralls for better visibility and reporting.
Closes #221.