-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds HTTP/2 and gRPC support to Martian Proxy #318
Conversation
Changes are opt-in via h2.Config being set in mitm.Config so have no impact on existing uses.
These changes should not be included in the pull request.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
github.com/golang/protobuf is deprecated.
Needed to correct CI error: ../../../golang.org/x/net/http2/client_conn_pool.go:305:6: undefined: errors.Is
While it could be useful in certain cases, partialProcessorAdapter breaks type-safety of the API, impeding readability.
This comment applies to both grpc.ProcessorFactory and h2.StreamProcessorFactory.
Minor comment cleanups.
Thanks for pointing this out, Adam.
Resolves issue #268 |
No description provided.