Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to pull #5411

Open
wants to merge 82 commits into
base: greenkeeper-acorn-4.0.1
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
82 commits
Select commit Hold shift + click to select a range
7f57f99
Bump to 1.2.1
Sep 8, 2016
6cdbdc8
chore(package): update gulp-load-plugins to version 1.3.0
greenkeeperio-bot Sep 9, 2016
645d841
Merge pull request #4731 from google/greenkeeper-gulp-load-plugins-1.3.0
sgomes Sep 13, 2016
f941a99
Add comment to be consistent with comments above other demo snippets
jojow Sep 13, 2016
609fc1b
Fix list class reference to display the proper modifier classes.
enniel Sep 14, 2016
88872e6
Fix search icon position in dashboard template
Mugen87 Sep 15, 2016
55a4082
chore(package): update acorn to version 4.0.3
greenkeeperio-bot Sep 16, 2016
b668213
Merge pull request #4762 from google/greenkeeper-acorn-4.0.3
sgomes Sep 22, 2016
263ecf3
chore(package): update jquery to version 3.1.1
greenkeeperio-bot Sep 22, 2016
07bd6fd
Add componentHanderConfig to config auto upgrade
AlexanderOtavka Sep 23, 2016
f90790b
Fix closure errors
AlexanderOtavka Sep 23, 2016
93304a8
Revert "Fix closure errors"
AlexanderOtavka Sep 23, 2016
2666977
Revert "Add componentHanderConfig to config auto upgrade"
AlexanderOtavka Sep 23, 2016
ef69a4a
Prevent component upgrades by catching events.
AlexanderOtavka Sep 23, 2016
24cb22f
chore(package): update gulp-mocha-phantomjs to version 0.12.0
greenkeeperio-bot Sep 24, 2016
621bdd2
Merge pull request #4789 from google/greenkeeper-gulp-mocha-phantomjs…
sgomes Sep 27, 2016
f711533
Add a missing space
nayzawoo Oct 2, 2016
9f025d4
fix
enniel Oct 4, 2016
fb59319
Merge pull request #4781 from AlexanderOtavka/initial-upgrade-config
sgomes Oct 4, 2016
f52e765
Merge pull request #4779 from google/greenkeeper-jquery-3.1.1
sgomes Oct 4, 2016
fde47f7
Fix "issue tracker" hyperlink in CONTRIBUTING.md .
apetro Oct 4, 2016
720deed
Fixed MaterialRadio.prototype.onChange_
ajchemist Sep 30, 2016
12e2829
fix radio unit test
Oct 7, 2016
75e7f9d
fix data-table unit test
Oct 7, 2016
8f58d1a
refix radio.js, mocha is true
Oct 7, 2016
c6a883a
Merge pull request #4813 from nayzawoo/patch-1
sgomes Oct 7, 2016
24e1b02
Merge pull request #4809 from aJchemist/patch-1
sgomes Oct 10, 2016
da66171
Fix alignment in list-control.html
ProZsolt Oct 10, 2016
3b8b0d1
Merge pull request #4833 from CodeGenTeam/fix-error
sgomes Oct 12, 2016
fcb8c35
Fix linting issue in radio.js
Oct 12, 2016
60e3886
Merge pull request #4838 from ProZsolt/patch-1
sgomes Oct 12, 2016
53204f6
chore(package): update gulp-sourcemaps to version 2.0.1
greenkeeperio-bot Oct 12, 2016
feca3a8
Merge pull request #4845 from google/greenkeeper-gulp-sourcemaps-2.0.1
sgomes Oct 12, 2016
4ee5202
feat(Card): enable border for mdl-card__supporting-text
leocaseiro Oct 14, 2016
b353f83
Add class to disable js layout switching
chajath Oct 18, 2016
14b6cb1
fix(tabs): Allow tab hrefs to point anywhere
MitchLillie Oct 19, 2016
4e901f0
Merge pull request #4849 from leocaseiro/enable-border-card-supportin…
sgomes Oct 25, 2016
40290b3
Merge pull request #4860 from MitchLillie/fix/allow-hrefs-in-tabs
sgomes Oct 25, 2016
faff9e1
fix ripple.js bug (#4865)
hanyuzhou2006 Oct 25, 2016
d672960
chore(package): update gulp-imagemin to version 3.1.0
greenkeeperio-bot Oct 28, 2016
2eaf506
Merge pull request #4885 from google/greenkeeper-gulp-imagemin-3.1.0
sgomes Oct 28, 2016
46493d5
Merge pull request #4859 from chajath/mdl-1.x
sgomes Nov 21, 2016
6f96b66
Update readme with mdl-layout__tab-manual-switch.
sgomes Nov 21, 2016
fbb370d
fix
enniel Dec 6, 2016
7c7b448
Merge pull request #4817 from enniel/fix-spinner-styles
sgomes Dec 7, 2016
e2df36d
fix(radio): add height and vertical-align
Dec 14, 2016
bdb5cae
Merge pull request #4978 from pndewit/mdl-1.x
sgomes Dec 15, 2016
0b2f959
Temporarily disable memory tests in drone due to timeouts.
sgomes Dec 15, 2016
730f1a7
chore(package): update gulp-sass to version 3.0.0
greenkeeperio-bot Dec 10, 2016
6c2b2ea
Merge pull request #4971 from google/greenkeeper-gulp-sass-3.0.0
sgomes Dec 15, 2016
5610263
chore(package): update babel-core to version 6.20.0
greenkeeperio-bot Dec 8, 2016
9fac88f
Fixing build after babel-core update.
Dec 15, 2016
b699ce9
Merge pull request #4966 from google/greenkeeper-babel-core-6.20.0
sgomes Dec 15, 2016
76b1fc9
Update most dependencies
Dec 15, 2016
7d7c86b
Updating JSCS and fixing linting errors.
Dec 15, 2016
2e98c1d
Merge pull request #4982 from google/sgomes-update-deps-2016-12
sgomes Dec 15, 2016
f92971e
sgomes-update-1.x-repo
Dec 16, 2016
388336c
_radio.scss: scale() instead of scale3d()
Abradoks Dec 19, 2016
aaf6966
Add mdl-card__menu docs. Fixes #1094
Dec 19, 2016
70fdbc8
Merge pull request #4987 from Abradoks/mdl-1.x
sgomes Dec 20, 2016
745f2dd
Bump to 1.3.0
Dec 21, 2016
b395350
Fix full width card action overflow in IE
lexaurin Jan 4, 2017
2265e3d
Remove invalid property.
Garbee Jan 30, 2017
245f19d
Fix #1335 (#5041)
malgirl Feb 24, 2017
dff2181
Updated README.md to communicate MCW as MDL v2 (#5023)
rystraum Feb 24, 2017
3caa5c3
chore(package): update gulp-zip to version 4.0.0 (#5018)
greenkeeperio-bot Feb 24, 2017
fd21836
Fix js lint issues (#5013)
MrMeison Feb 24, 2017
03120bb
Add Snackbar hide method
joaofnds Jan 21, 2017
0c710aa
Fix checked/unchecked style for checkbox
MrMeison Jan 18, 2017
8487c64
Fixed minor typo in dialog README
gilbertginsberg Feb 27, 2017
4109256
Fixed dead link for `CONTRIBUTING.md` in README.md
MewX Apr 26, 2017
0463566
Fix the aria-hidden setting for the case when a fixed drawer is open.…
jorr-at-google Jun 15, 2017
5324ced
Add expansion component
Garbee Mar 28, 2017
71ad03e
Automatic uncheck header checkbox
sebtiz13 Apr 2, 2017
47518d5
Update data-table.js
sebtiz13 Apr 2, 2017
2ae1382
Update data-table.js
sebtiz13 Apr 2, 2017
20b941b
Add public method setTab to set the active tab programmatically
eKoopmans Apr 12, 2017
3b749f1
Update _variables.scss
plug-n-play Jun 23, 2017
c5efd97
Remove mouseup event on slider to let change event occur.
Garbee Mar 28, 2017
df6196d
set is_dirty when placeholder exists
harleyb16 May 17, 2017
b848826
Check placeholder value when setting dirty state.
Garbee Jun 27, 2017
60f441a
Fix placeholder check for dirty state
Garbee Jun 27, 2017
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .drone.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ build:
- Xvfb $DISPLAY &
- curl -sSLo chrome.deb $CHROME && dpkg -i chrome.deb
- curl -sSLo driver.zip $WEBDRIVER && unzip -q driver.zip -d /usr/bin
- node test/memory/test.js
publish:
# see http://addons.drone.io/google_cloud_storage/ for details
gcs:
Expand Down
5 changes: 1 addition & 4 deletions .jscsrc
Original file line number Diff line number Diff line change
@@ -1,16 +1,13 @@
{
"preset": "google",
"esnext": true,
"disallowSpacesInAnonymousFunctionExpression": null,
"validateLineBreaks": "LF",
"validateIndentation": 2,
"excludeFiles": ["node_modules/**"],
"maximumLineLength": 130,
"validateQuoteMarks": "'",
"requireDotNotation": false,
"requireCamelCaseOrUpperCaseIdentifiers": null,
"additionalRules": ["./utils/jscs-rules/*.js", "../utils/jscs-rules/*.js"],
"closureCamelCase": true,
"requireCamelCaseOrUpperCaseIdentifiers": {"allowedPrefixes": ["opt_"]},
"jsDoc": {
"checkAnnotations": {
"preset": "closurecompiler",
Expand Down
3 changes: 2 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ Please provide any URLs or screenshots of good examples of usage of this compone
If you would like to implement a new feature then consider what kind of change it is:

* **Major Changes** that you wish to contribute to the project should be discussed first on our
[issue tracker][https://github.com/google/material-design-lite/issues] so that we can better coordinate our efforts, prevent
[issue tracker][] so that we can better coordinate our efforts, prevent
duplication of work, and help you to craft the change so that it is successfully accepted into the
project.
* **Small Changes** can be crafted and submitted to the [GitHub Repository][github] as a Pull Request.
Expand Down Expand Up @@ -223,6 +223,7 @@ changes to be accepted, the CLA must be signed. It's a quick process, we promise
*This guide was inspired by the [AngularJS contribution guidelines](https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md).*

[github]: https://github.com/google/material-design-lite
[issue tracker]: https://github.com/google/material-design-lite/issues
[individual-cla]: http://code.google.com/legal/individual-cla-v1.0.html
[corporate-cla]: http://code.google.com/legal/corporate-cla-v1.0.html
[js-style-guide]: http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml
Expand Down
53 changes: 22 additions & 31 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,25 +14,21 @@ static content websites. It doesn't rely on any JavaScript frameworks or
libraries. Optimized for cross-device use, gracefully degrades in older
browsers, and offers an experience that is accessible from the get-go.

## Want to contribute?

If you found a bug, have any questions or want to contribute. Follow our
[guidelines](https://github.com/google/material-design-lite/blob/master/CONTRIBUTING.md),
and help improve the Material Design Lite. For more information visit our
[wiki](https://github.com/google/material-design-lite/wiki).
> ### Limited support

If you are submitting a bug fix or a new component for the 1.x line, please send those into `mdl-1.x` currently.
> Material Design Lite is now in limited support, with development having moved to the
> [Material Components for the web](https://github.com/material-components/material-components-web) repository.

The `master` branch is where we are working on 2.0.
It is currently **highly** experimental and no support building or using it will be provided.
> No further development is taking place in MDL by the core team, but we are happy to review PRs, fix critical bugs and
> push out new releases. No breaking changes will be accepted.

## Use MDL on your site?

**This document is targeted at developers that will contribute to or compile
MDL. If you are looking to use MDL on your website or web app please head to
[getmdl.io](http://getmdl.io).**

## Browser Support in v1
## Browser Support


| IE9 | IE10 | IE11 | Chrome | Opera | Firefox | Safari | Chrome (Android) | Mobile Safari |
Expand All @@ -42,21 +38,6 @@ MDL. If you are looking to use MDL on your website or web app please head to
A-grade browsers are fully supported. B-grade browsers will gracefully degrade
to our CSS-only experience.

## Browser Support in v2 (in development)

Supported evergreen browsers:

- Chrome
- Edge
- Firefox
- Opera

Supported versioned browsers:

- Internet Explorer 11
- Safari 8
- Mobile Safari 8

### Download / Clone

Clone the repo using Git:
Expand Down Expand Up @@ -84,12 +65,22 @@ production. Use a tagged state of the repository, npm, or bower for stability!

## Feature requests

If you find MDL doesn't contain a particular component you think would be
useful, please check the issue tracker in case work has already started on it.
If not, you can request a [new component](https://github.com/Google/material-design-lite/issues/new?title=[Component%20Request]%20{Component}&body=Please%20include:%0A*%20Description%0A*%20Material%20Design%20Spec%20link%0A*%20Use%20Case%28s%29).
Please keep in mind that one of the goals of MDL is to adhere to the Material
Design specs and therefore some requests might not be within the scope of this
project.
MDL is currently in limited support mode, with no further development taking place by the core team.
We are happy to accept and review pull requests for new functionality, however, as long as there are no breaking
changes.

## Want to contribute?

If you found a bug, have any questions or want to contribute. Follow our
[guidelines](https://github.com/google/material-design-lite/blob/mdl-1.x/CONTRIBUTING.md),
and help improve the Material Design Lite. For more information visit our
[wiki](https://github.com/google/material-design-lite/wiki).

Please use the default branch, `mdl-1.x`.

Take note that [Material Components for Web](https://github.com/material-components/material-components-web), which is MDL v2, is under early Alpha stages (which means everything is a moving target, and we can change anything at any moment). Use with caution.

However, we would absolutely love to have people testing MCW and provide feedback about their experiences using it, especially integrating with other frameworks and libraries.

## License

Expand Down
2 changes: 1 addition & 1 deletion bower.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "material-design-lite",
"version": "1.2.0",
"version": "1.3.0",
"homepage": "https://github.com/google/material-design-lite",
"authors": [
"Material Design Lite team"
Expand Down
11 changes: 11 additions & 0 deletions docs/_pages/components.md
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,17 @@ categories:
limited cross-browser support. To ensure support across all modern
browsers, please consider using a polyfill or creating your own.
There is no polyfill included with MDL.
- name: expansion
title: Expansion
description: Collapsible content sections.
components:
- name: expansion
class: mdl-expansion
snippets:
- snippet_group:
- caption: Example Expansion
file: expansion.html
full_width: true
- name: layout
title: Layout
description: Building blocks for constructing a page layout.
Expand Down
8 changes: 4 additions & 4 deletions gulpfile.babel.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
*
*/

// jscs:disable jsDoc
// jscs:disable jsDoc

'use strict';

Expand All @@ -26,7 +26,7 @@ import fs from 'fs';
import path from 'path';
import mergeStream from 'merge-stream';
import del from 'del';
import vinylPaths from'vinyl-paths';
import vinylPaths from 'vinyl-paths';
import runSequence from 'run-sequence';
import browserSync from 'browser-sync';
import through from 'through2';
Expand Down Expand Up @@ -219,12 +219,12 @@ gulp.task('closure', () => {
compilerPath: 'node_modules/google-closure-compiler/compiler.jar',
fileName: 'material.closure.min.js',
compilerFlags: {
// jscs:disable closureCamelCase
// jscs:disable requireCamelCaseOrUpperCaseIdentifiers
compilation_level: 'ADVANCED_OPTIMIZATIONS',
language_in: 'ECMASCRIPT6_STRICT',
language_out: 'ECMASCRIPT5_STRICT',
warning_level: 'VERBOSE'
// jscs:enable closureCamelCase
// jscs:enable requireCamelCaseOrUpperCaseIdentifiers
}
}))
.pipe(gulp.dest('./dist'));
Expand Down
47 changes: 26 additions & 21 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,57 +1,59 @@
{
"name": "material-design-lite",
"version": "1.2.0",
"version": "1.3.0",
"description": "Material Design Components in CSS, JS and HTML",
"private": true,
"license": "Apache-2.0",
"author": "Google",
"repository": "google/material-design-lite",
"main": "dist/material.min.js",
"devDependencies": {
"acorn": "^3.3.0",
"babel-core": "^5.8.25",
"acorn": "^4.0.3",
"babel-core": "^6.20.0",
"babel-preset-es2015": "^6.18.0",
"browser-sync": "^2.2.3",
"chai": "^3.3.0",
"chai-jquery": "^2.0.0",
"del": "^2.0.2",
"drool": "^0.3.1",
"drool": "^0.4.0",
"escodegen": "^1.6.1",
"google-closure-compiler": "",
"gulp": "^3.9.0",
"gulp-autoprefixer": "^3.0.2",
"gulp-cache": "^0.3.0",
"gulp-closure-compiler": "^0.3.1",
"gulp-cache": "^0.4.5",
"gulp-closure-compiler": "^0.4.0",
"gulp-concat": "^2.4.1",
"gulp-connect": "^5.0.0",
"gulp-css-inline-images": "^0.1.1",
"gulp-csso": "1.0.0",
"gulp-file": "^0.2.0",
"gulp-file": "^0.3.0",
"gulp-flatten": "^0.3.1",
"gulp-front-matter": "^1.2.2",
"gulp-header": "^1.2.2",
"gulp-if": "^2.0.0",
"gulp-iife": "^0.1.0",
"gulp-imagemin": "^2.2.1",
"gulp-jscs": "^3.0.1",
"gulp-jshint": "^1.6.3",
"gulp-load-plugins": "^0.10.0",
"gulp-iife": "^0.3.0",
"gulp-imagemin": "^3.1.0",
"gulp-jscs": "^4.0.0",
"gulp-jshint": "^2.0.4",
"gulp-load-plugins": "^1.3.0",
"gulp-marked": "^1.0.0",
"gulp-mocha-phantomjs": "^0.10.1",
"gulp-open": "^1.0.0",
"gulp-mocha-phantomjs": "^0.12.0",
"gulp-open": "^2.0.0",
"gulp-rename": "^1.2.0",
"gulp-replace": "^0.5.3",
"gulp-sass": "2.0.*",
"gulp-shell": "^0.4.2",
"gulp-sass": "3.0.0",
"gulp-shell": "^0.5.2",
"gulp-size": "^2.0.0",
"gulp-sourcemaps": "^1.3.0",
"gulp-sourcemaps": "^2.0.1",
"gulp-subtree": "^0.1.0",
"gulp-tap": "^0.1.3",
"gulp-uglify": "^2.0.0",
"gulp-util": "^3.0.4",
"gulp-zip": "^3.0.2",
"gulp-zip": "^4.0.0",
"humanize": "0.0.9",
"jquery": "^2.1.3",
"jshint-stylish": "^2.0.1",
"jquery": "^3.1.1",
"jshint": "^2.9.4",
"jshint-stylish": "^2.2.1",
"merge-stream": "^1.0.0",
"mocha": "^3.0.2",
"prismjs": "0.0.1",
Expand All @@ -67,6 +69,9 @@
"test": "gulp && git status | grep 'working directory clean' >/dev/null || (echo 'Please commit all changes generated by building'; exit 1)"
},
"babel": {
"only": "gulpfile.babel.js"
"only": "gulpfile.babel.js",
"presets": [
"es2015"
]
}
}
2 changes: 1 addition & 1 deletion src/_variables.scss
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
* -----Chip
*
* Even though all variables have the `!default` directive, most of them
* should not be changed as they are dependent one another. This can cause
* should not be changed as they are dependent on one another. This can cause
* visual distortions (like alignment issues) that are hard to track down
* and fix.
*/
Expand Down
1 change: 0 additions & 1 deletion src/animation/demo.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/

/**
* Class constructor for Animation MDL component.
* Implements MDL component design pattern defined at:
Expand Down
1 change: 1 addition & 0 deletions src/badge/snippets/badge-on-icon-icon.html
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
<!-- Icon badge on icon -->
<div class="material-icons mdl-badge mdl-badge--overlap" data-badge="♥">account_box</div>
1 change: 0 additions & 1 deletion src/button/button.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/

(function() {
'use strict';

Expand Down
1 change: 1 addition & 0 deletions src/card/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -125,3 +125,4 @@ The MDL CSS classes apply various predefined visual and behavioral enhancements
| `mdl-card__media` | Defines div as a card media container | Required on "inner" media div |
| `mdl-card__supporting-text` | Defines div as a card body text container and assigns appropriate text characteristics to body text | Required on "inner" body text div; text goes directly inside the div with no intervening containers |
| `mdl-card__actions` | Defines div as a card actions container and assigns appropriate text characteristics to actions text | Required on "inner" actions div; content goes directly inside the div with no intervening containers |
| `mdl-card__menu` | Defines element as top right menu button | Optional. Should be a child of the `mdl-card` element. |
5 changes: 4 additions & 1 deletion src/card/_card.scss
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@
color: $card-text-color;
display: block;
display: flex;
justify-content: stretch;
line-height: normal;
padding: $card-vertical-padding $card-horizontal-padding;
perspective-origin: $card-title-perspective-origin-x $card-title-perspective-origin-y;
Expand Down Expand Up @@ -84,6 +83,10 @@
overflow: hidden;
padding: $card-vertical-padding $card-horizontal-padding;
width: 90%;

&.mdl-card--border {
border-bottom: 1px solid $card-border-color;
}
}

.mdl-card__actions {
Expand Down
7 changes: 4 additions & 3 deletions src/checkbox/_checkbox.scss
Original file line number Diff line number Diff line change
Expand Up @@ -122,15 +122,16 @@

background: transparent;
@include material-animation-default(0.28s);
transition-property: background;
transition-property: background-image;

.mdl-checkbox.is-checked & {
background: $checkbox-color url("#{$checkbox-image-path}/tick.svg?embed");
background-color: $checkbox-color;
background-image: url("#{$checkbox-image-path}/tick.svg?embed");
}

fieldset[disabled] .mdl-checkbox.is-checked &,
.mdl-checkbox.is-checked.is-disabled & {
background: $checkbox-disabled-color url("#{$checkbox-image-path}/tick.svg?embed");
background-color: $checkbox-disabled-color;
}
}

Expand Down
1 change: 0 additions & 1 deletion src/checkbox/checkbox.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/

(function() {
'use strict';

Expand Down
8 changes: 5 additions & 3 deletions src/data-table/data-table.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/

(function() {
'use strict';

Expand Down Expand Up @@ -77,6 +76,9 @@
row.classList.add(this.CssClasses_.IS_SELECTED);
} else {
row.classList.remove(this.CssClasses_.IS_SELECTED);
if (this.headerCheckbox['MaterialCheckbox'].inputElement_.checked) {
this.headerCheckbox['MaterialCheckbox'].uncheck();
}
}
}.bind(this);
}
Expand Down Expand Up @@ -147,8 +149,8 @@

if (this.element_.classList.contains(this.CssClasses_.SELECTABLE)) {
var th = document.createElement('th');
var headerCheckbox = this.createCheckbox_(null, rows);
th.appendChild(headerCheckbox);
this.headerCheckbox = this.createCheckbox_(null, rows);
th.appendChild(this.headerCheckbox);
firstHeader.parentElement.insertBefore(th, firstHeader);

for (var i = 0; i < rows.length; i++) {
Expand Down
2 changes: 1 addition & 1 deletion src/dialog/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ For other browsers you will need to include the [dialog polyfill](https://github
Once you have dialog support create a dialog element.
The element when using the polyfill **must** be a child of the `body` element.
Within that container, add a content element with the class `mdl-dialog__content`.
Add you content, then create an action container with the class `mdl-dialog__actions`.
Add your content, then create an action container with the class `mdl-dialog__actions`.
Finally for the markup, add your buttons within this container for triggering dialog functions.

Keep in mind, the order is automatically reversed for actions.
Expand Down
Loading