Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

presubmit should check the version of the script or fail more gracefully #146

Open
nshahan opened this issue Apr 10, 2019 · 0 comments
Open

Comments

@nshahan
Copy link

nshahan commented Apr 10, 2019

I just confused myself when I ran mono_repo presubmit and got the same error printed to the file for all actions "PKG environment variable must be set!".

I finally just ran mono_repo travis to regenerate the script and this fixed everything. Maybe the command should detect a version mismatch with the script and do something smarter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants