-
Notifications
You must be signed in to change notification settings - Fork 360
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Emulate IMM32 vertical writing protocol in TSF
mozc_renderer indeed has had logic to avoid its candidate window from being placed over the composing text in vertical writing scenario. This logic was, however, fully implemented only in Mozc's IMM32 DLLs. Mozc's TIP modules have not yet propagated the same information to mozc_renderer. As a result, Mozc's candidate window always overwraps composing text in the vertical writing mode, and Chromium ended up implementing a workaround for this behavior [1]. With this commit, Mozc's TIP DLLs start filling CharacterPosition in the same way as Mozc's IMM32 DLLs used to do in the vertical writing mode. Now the observable behavior in the vertical writing mode should be the same as IMM32 Mozc. Closes #362. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/4023235 PiperOrigin-RevId: 573515844
- Loading branch information
1 parent
fe9665d
commit 1212d91
Showing
5 changed files
with
73 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters