Skip to content

Commit

Permalink
session_handler_scenario_test: fix scenario file path, remove manual …
Browse files Browse the repository at this point in the history
…and nofastbuild tags

- Fix scenario data file path (changed in cl/554470237)
- Remove manual and nofastbuild tags to run the tests in presubmit. They run significantly faster after sharding and can be included in the fastbuild test set.

PiperOrigin-RevId: 556968260
  • Loading branch information
yuryu authored and hiroyuki-komatsu committed Aug 15, 2023
1 parent e5a59ca commit aa082de
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
7 changes: 1 addition & 6 deletions src/session/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -779,9 +779,7 @@ mozc_cc_test(
requires_full_emulation = False,
shard_count = 8,
tags = [
"manual",
"noandroid", # TODO(b/73698251): disabled due to errors
"nofastbuild",
],
deps = [
":request_test_util",
Expand All @@ -790,10 +788,6 @@ mozc_cc_test(
"//base:file_stream",
"//base:file_util",
"//base:number_util",
"//base:util",
"//base/protobuf:descriptor",
"//base/protobuf:message",
"//base/protobuf:text_format",
"//engine:engine_interface",
"//engine:mock_data_engine_factory",
"//prediction:user_history_predictor",
Expand All @@ -803,6 +797,7 @@ mozc_cc_test(
"//testing:mozctest",
"//usage_stats:usage_stats_testing_util",
"@com_google_absl//absl/status",
"@com_google_absl//absl/status:statusor",
"@com_google_absl//absl/strings",
"@com_google_absl//absl/strings:str_format",
],
Expand Down
3 changes: 2 additions & 1 deletion src/session/session_handler_scenario_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
#include "testing/mozctest.h"
#include "usage_stats/usage_stats_testing_util.h"
#include "absl/status/status.h"
#include "absl/status/statusor.h"
#include "absl/strings/str_format.h"
#include "absl/strings/string_view.h"

Expand Down Expand Up @@ -402,7 +403,7 @@ void ParseLine(SessionHandlerInterpreter &handler, const std::string &line) {
TEST_P(SessionHandlerScenarioTest, TestImplBase) {
// Open the scenario file.
const absl::StatusOr<std::string> scenario_path =
mozc::testing::GetSourceFile({GetParam()});
mozc::testing::GetSourceFile({MOZC_DICT_DIR_COMPONENTS, GetParam()});
ASSERT_TRUE(scenario_path.ok()) << scenario_path.status();
LOG(INFO) << "Testing " << FileUtil::Basename(*scenario_path);
InputFileStream input_stream(*scenario_path);
Expand Down

0 comments on commit aa082de

Please sign in to comment.