Fix Fib parsing #296
Merged
Fix Fib parsing #296
+74
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stapelberg
reviewed
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per issue #291, FIB objects are not parsed although the implementation exists. This PR fixes this issue.
Additionally, the initial FIB implementation did not parse the object properly so I changed that as well. The initial implementation assumed that result field is uint32 used as flag, but per original libnftnl implementation, I would say that result is uint32 referring to only a single value: https://git.netfilter.org/libnftnl/tree/include/linux/netfilter/nf_tables.h?id=ff37c01480cd0b938658d180ff5c7b1958ad250f#n1605
Since the initial implementation used booleans, I decided to not change that for this PR.