Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an action to export pending-delete domains #2595

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gbrodman
Copy link
Collaborator

@gbrodman gbrodman commented Oct 22, 2024

This will allow our partners to know when domains will expire, versus having to constantly request various domains to see when they'll drop. Hopefully this reduces load on us.


This change is Reviewable

This will allow our partners to know when domains will expire, versus
having to constantly request various domains to see when they'll drop.
Hopefully this reduces load on us.
Copy link
Member

@CydeWeys CydeWeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not include domains in the redemption grace period per partner expectations, also it's easier to implement this as part of https://cs.opensource.google/nomulus/nomulus/+/master:core/src/main/java/google/registry/export/ExportDomainListsAction.java (which is already querying this same data anyway).

And you never grabbed the bug https://buganizer.corp.google.com/issues/345516564 , when I would've been able to let you know these design ideas/details prior to spending time on implementation.

Reviewable status: 0 of 4 files reviewed, all discussions resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants