Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

charts/timesketch Add ability to provide existing config through ConfigMap and update docs around config updates #165

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

wajihyassine
Copy link
Member

@wajihyassine wajihyassine commented Sep 13, 2024

Description of the change

Adds documentation around the various ways of updating Timesketch configs and allows configs to be provided outside of the Helm chart through a ConfigMap

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Newly added variables are documented in the values.yaml
  • Title of the pull request is descriptive

@wajihyassine wajihyassine marked this pull request as ready for review September 13, 2024 21:24
Copy link
Collaborator

@jkppr jkppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wajihyassine wajihyassine merged commit 8678403 into main Sep 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants