Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: update golang to latest minor version of 1.22 #12801

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

catenacyber
Copy link
Contributor

cc @guidovranken as I see cryptofuzz is using go1.22.7

Should fix ngolo-fuzzing build failure
https://issues.oss-fuzz.com/issues/379159151

go tool dist: go1.22.1 does not meet the minimum bootstrap requirement of go1.22.6 or later

@catenacyber
Copy link
Contributor Author

@AdamKorcz would you know who can take this in ?

@catenacyber
Copy link
Contributor Author

@DonggeLiu Can this PR get a review ?

@DonggeLiu
Copy link
Contributor

Thanks @AdamKorcz

@DonggeLiu
Copy link
Contributor

/gcbrun trial_build.py golang --fuzzing-engines libfuzzer --sanitizers coverage address

@catenacyber
Copy link
Contributor Author

Trial build failure seems unrelated (centipede)

@DavidKorczynski
Copy link
Collaborator

The centipede build should be working

@DavidKorczynski
Copy link
Collaborator

/gcbrun trial_build.py golang --fuzzing-engines libfuzzer --sanitizers coverage address

@DavidKorczynski
Copy link
Collaborator

/gcbrun trial_build.py golang --fuzzing-engines libfuzzer --sanitizers coverage address

@catenacyber
Copy link
Contributor Author

Why did the trial build fail ?

@DavidKorczynski
Copy link
Collaborator

I'm not sure why it failed, the log isn't showing any explicit issues as such. I see:

Step #1: Step #1: #11 sha256:55520b9d95ba838fedafe4514d6ec6e2c6ec484c7794d95d0ed2ddef3eaae1a5
Step #1: Step #1: #11 DONE 0.0s
Step #1: Step #1: 
Step #1: Step #1: #6 importing cache manifest from gcr.io/oss-fuzz-base/base-clang-testing-go-ngolo-1229
Step #1: Step #1: #6 sha256:2c343b2839d0c820056ee3d0b2dea4ed39b8d49984dd2fa10d40047212f05ce3
Step #1: Step #1: #6 ERROR: gcr.io/oss-fuzz-base/base-clang-testing-go-ngolo-1229:latest: not found
Step #1: Step #1: 
Step #1: Step #1: #4 importing cache manifest from gcr.io/oss-fuzz-base/base-clang

but I don't think is the issue -- later on it performs the same steps and it's okay.

@DavidKorczynski
Copy link
Collaborator

/gcbrun trial_build.py golang --fuzzing-engines libfuzzer --sanitizers coverage address

@catenacyber
Copy link
Contributor Author

ERROR: (gcloud.builds.submit) INVALID_ARGUMENT: invalid build: invalid .steps field: build step #1 - "build-x86_64": the ID is not unique

gcbrun does not seem to work so well after a few tries...

What should we do ?

@DonggeLiu
Copy link
Contributor

Strange that the errors are different, I don't think they are caused by this PR.
Rerunning the trial build just in case they are flaky.

@DonggeLiu
Copy link
Contributor

/gcbrun trial_build.py golang --fuzzing-engines libfuzzer --sanitizers coverage address

@catenacyber
Copy link
Contributor Author

@DonggeLiu the gcbrun seems to hit another unrelated error :
ERROR: (gcloud.builds.submit) INVALID_ARGUMENT: invalid build: invalid .steps field: build step #1 - "build-x86_64": the ID is not unique

What should we do to get this in and fix ngolo-fuzzing ?

@DavidKorczynski
Copy link
Collaborator

hmm, I think this may need rebasing

@DavidKorczynski
Copy link
Collaborator

/gcbrun trial_build.py golang --fuzzing-engines libfuzzer --sanitizers coverage address

@catenacyber
Copy link
Contributor Author

Thanks for rebasing, what is the failure ? I do not have access to the logs on GC

@DavidKorczynski
Copy link
Collaborator

From the logs I can't see what the actual error is wrt. failed trial build. @oliverchang @DonggeLiu can you see anything that fails?

@DavidKorczynski
Copy link
Collaborator

So it looks like the problem is that no actual projects are tested:

Step #1: Failed builds: 0/0, {}

@DavidKorczynski
Copy link
Collaborator

perhaps because it's should be go rather than golang in the trial build

@DavidKorczynski
Copy link
Collaborator

/gcbrun trial_build.py go --fuzzing-engines libfuzzer --sanitizers coverage address

@DavidKorczynski
Copy link
Collaborator

perhaps because it's should be go rather than golang in the trial build

I think this is it.

@DavidKorczynski
Copy link
Collaborator

Yep, can confirm things are running now. Apologies for the delay @catenacyber -- this should be good to go once the trial build finishes

@catenacyber
Copy link
Contributor Author

🤞

@catenacyber
Copy link
Contributor Author

So is timed out good enough ?

@DavidKorczynski
Copy link
Collaborator

The only project failing is not due to this PR. This is good to go.

@DavidKorczynski DavidKorczynski merged commit 9c210fd into google:master Jan 7, 2025
18 of 19 checks passed
@catenacyber
Copy link
Contributor Author

https://issues.oss-fuzz.com/issues/379159151 verified 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants