-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra: update golang to latest minor version of 1.22 #12801
Conversation
@AdamKorcz would you know who can take this in ? |
@DonggeLiu Can this PR get a review ? |
Thanks @AdamKorcz |
/gcbrun trial_build.py golang --fuzzing-engines libfuzzer --sanitizers coverage address |
Trial build failure seems unrelated (centipede) |
The centipede build should be working |
/gcbrun trial_build.py golang --fuzzing-engines libfuzzer --sanitizers coverage address |
71b9a04
to
c8d7ad8
Compare
/gcbrun trial_build.py golang --fuzzing-engines libfuzzer --sanitizers coverage address |
Why did the trial build fail ? |
I'm not sure why it failed, the log isn't showing any explicit issues as such. I see: Step #1: Step #1: #11 sha256:55520b9d95ba838fedafe4514d6ec6e2c6ec484c7794d95d0ed2ddef3eaae1a5
Step #1: Step #1: #11 DONE 0.0s
Step #1: Step #1:
Step #1: Step #1: #6 importing cache manifest from gcr.io/oss-fuzz-base/base-clang-testing-go-ngolo-1229
Step #1: Step #1: #6 sha256:2c343b2839d0c820056ee3d0b2dea4ed39b8d49984dd2fa10d40047212f05ce3
Step #1: Step #1: #6 ERROR: gcr.io/oss-fuzz-base/base-clang-testing-go-ngolo-1229:latest: not found
Step #1: Step #1:
Step #1: Step #1: #4 importing cache manifest from gcr.io/oss-fuzz-base/base-clang but I don't think is the issue -- later on it performs the same steps and it's okay. |
/gcbrun trial_build.py golang --fuzzing-engines libfuzzer --sanitizers coverage address |
gcbrun does not seem to work so well after a few tries... What should we do ? |
Strange that the errors are different, I don't think they are caused by this PR. |
/gcbrun trial_build.py golang --fuzzing-engines libfuzzer --sanitizers coverage address |
@DonggeLiu the gcbrun seems to hit another unrelated error : What should we do to get this in and fix ngolo-fuzzing ? |
hmm, I think this may need rebasing |
/gcbrun trial_build.py golang --fuzzing-engines libfuzzer --sanitizers coverage address |
Thanks for rebasing, what is the failure ? I do not have access to the logs on GC |
From the logs I can't see what the actual error is wrt. failed trial build. @oliverchang @DonggeLiu can you see anything that fails? |
So it looks like the problem is that no actual projects are tested:
|
perhaps because it's should be |
/gcbrun trial_build.py go --fuzzing-engines libfuzzer --sanitizers coverage address |
I think this is it. |
Yep, can confirm things are running now. Apologies for the delay @catenacyber -- this should be good to go once the trial build finishes |
🤞 |
So is timed out good enough ? |
The only project failing is not due to this PR. This is good to go. |
https://issues.oss-fuzz.com/issues/379159151 verified 🎉 |
cc @guidovranken as I see cryptofuzz is using go1.22.7
Should fix ngolo-fuzzing build failure
https://issues.oss-fuzz.com/issues/379159151