Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add "slices" import back in #1395

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

michaelkedar
Copy link
Member

#1329 removed the slices import in vulnerability_result.go, because it was no longer using it.
At the same time, #1385 added a new usage of the module.

Add the import back to make osv-scanner build again.

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.02%. Comparing base (581d1a3) to head (a5db8f6).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1395      +/-   ##
==========================================
+ Coverage   68.76%   69.02%   +0.25%     
==========================================
  Files         184      185       +1     
  Lines       17719    17869     +150     
==========================================
+ Hits        12185    12334     +149     
- Misses       4875     4876       +1     
  Partials      659      659              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hogo6002 hogo6002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Michael!

@michaelkedar michaelkedar merged commit 9a303ec into google:main Nov 12, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants