Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: increase timeout for golangci-lint #1467

Merged
merged 2 commits into from
Dec 24, 2024
Merged

chore: increase timeout for golangci-lint #1467

merged 2 commits into from
Dec 24, 2024

Conversation

cuixq
Copy link
Contributor

@cuixq cuixq commented Dec 24, 2024

Recently golangci-lint timeouts quite often, as suggested, increase the timeout to 5m.

@cuixq cuixq changed the title ci: increase timeout for golangci-lint chore: increase timeout for golangci-lint Dec 24, 2024
@cuixq cuixq marked this pull request as ready for review December 24, 2024 01:08
@cuixq cuixq requested a review from another-rex December 24, 2024 01:08
@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.33%. Comparing base (bd2b403) to head (85d6cc2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1467   +/-   ##
=======================================
  Coverage   67.33%   67.33%           
=======================================
  Files         194      194           
  Lines       18354    18354           
=======================================
  Hits        12359    12359           
  Misses       5325     5325           
  Partials      670      670           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@another-rex
Copy link
Collaborator

Not sure if this will fix it though, it doesn't seem to take that long when it is working correctly. (33s for this PR)

@cuixq cuixq merged commit d9660dc into main Dec 24, 2024
15 checks passed
@cuixq cuixq deleted the cuixq-patch-1 branch December 24, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants