feat: Add artifact extractors #1531
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hogo6002
approved these changes
Jan 24, 2025
| // Patch python package names to be normalized | ||
| if pkg.Ecosystem().Ecosystem == osvschema.EcosystemPyPI { | ||
| // per https://peps.python.org/pep-0503/#normalized-names | ||
| return strings.ToLower(cachedregexp.MustCompile(`[-_.]+`).ReplaceAllLiteralString(pkg.Inventory.Name, "-")) |
There was a problem hiding this comment.
Should we add a TODO to remove this after the API query change is deployed to production?
There was a problem hiding this comment.
Yep good catch, I'll probably remove this entirely since I don't plan on merging this PR in until next week.
| // Replace this with an actual implementation in OSV-Scalibr (potentially via full filesystem accountability). | ||
| for _, psr := range scanResult.PackageScanResults { | ||
| if strings.HasPrefix(psr.PackageInfo.Location(), "usr/") { | ||
| if (strings.HasPrefix(psr.PackageInfo.Location(), "usr/") && psr.PackageInfo.Ecosystem().Ecosystem == osvschema.EcosystemGo) || |
There was a problem hiding this comment.
nit: This logic for annotation seems quite complex now. Can we add some examples in the comments to clarify which cases will be annotated?
oliverchang
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the python wheel.egg and java jar archive extractors.
renames artifacts source from lockfile to artifact, so output will actually be "artifact:".
Reenable some of the image scanning tests accidentally removed from a previous PR. The unrelated snapshot changes will be from that.
This PR is not ready to be merged in yet, waiting on a osv-scalibr change to be merged in first. (google/osv-scalibr#407)