third_party: Remove includes attribute

Bug: 378564135 Change-Id: I6e05379ebfb72b341546f5d967fbbde521ffe276 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/262832 Reviewed-by: Armando Montanez <[email protected]> Commit-Queue: Auto-Submit <[email protected]> Docs-Not-Needed: Ted Pudlik <[email protected]> Presubmit-Verified: CQ Bot Account <[email protected]> Lint: Lint 🤖 <[email protected]> Pigweed-Auto-Submit: Ted Pudlik <[email protected]>
google · Jan 25, 2025 · 94476c3 · 94476c3
1 parent 9f528bc
commit 94476c3
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 9 deletions.
diff --git a/pw_presubmit/py/pw_presubmit/pigweed_presubmit.py b/pw_presubmit/py/pw_presubmit/pigweed_presubmit.py
@@ -1613,13 +1613,8 @@ def owners_lint_checks(ctx: PresubmitContext):
     "//targets/rp2040:freertos_config",
     "//targets/stm32f429i_disc1_stm32cube:freertos_config",
     "//targets/stm32f429i_disc1_stm32cube:hal_config",
-    "//third_party/boringssl:sysdeps",
-    "//third_party/chromium_verifier:pthread",
     "//third_party/fuchsia:fit_impl",
     "//third_party/fuchsia:stdcompat",
-    "//third_party/mbedtls:default_config",
-    "//third_party/smartfusion_mss:debug_config",
-    "//third_party/smartfusion_mss:default_config",
     # keep-sorted: end
 )
 

diff --git a/third_party/boringssl/BUILD.bazel b/third_party/boringssl/BUILD.bazel
@@ -26,7 +26,7 @@ cc_library(
     name = "sysdeps",
     hdrs = ["sysdeps/sys/socket.h"],
     copts = ["-Wno-unused-parameter"],
-    includes = ["sysdeps"],
+    strip_include_prefix = "sysdeps",
     target_compatible_with = incompatible_with_mcu(),
     deps = [
         "//pw_assert",

diff --git a/third_party/chromium_verifier/BUILD.bazel b/third_party/chromium_verifier/BUILD.bazel
@@ -17,5 +17,5 @@ cc_library(
     hdrs = [
         "public/chromium_verifier/pthread/pthread.h",
     ],
-    includes = ["public/chromium_verifier/pthread"],
+    strip_include_prefix = "public/chromium_verifier/pthread",
 )
diff --git a/third_party/fuchsia/BUILD.bazel b/third_party/fuchsia/BUILD.bazel
@@ -53,6 +53,9 @@ cc_library(
         "repo/sdk/lib/fit/include/lib/fit/result.h",
         "repo/sdk/lib/fit/include/lib/fit/traits.h",
     ],
+    # TODO: https://pwbug.dev/378564135 - Replacing this with
+    # strip_include_prefix leads to errors when trying to #include internal
+    # headers within this library.
     includes = ["repo/sdk/lib/fit/include"],
     deps = [
         ":stdcompat",
@@ -80,6 +83,9 @@ cc_library(
         "repo/sdk/lib/stdcompat/include/lib/stdcompat/utility.h",
         "repo/sdk/lib/stdcompat/include/lib/stdcompat/version.h",
     ],
+    # TODO: https://pwbug.dev/378564135 - Replacing this with
+    # strip_include_prefix leads to errors when trying to #include internal
+    # headers within this library.
     includes = ["repo/sdk/lib/stdcompat/include"],
 )
 

diff --git a/third_party/mbedtls/BUILD.bazel b/third_party/mbedtls/BUILD.bazel
@@ -29,5 +29,5 @@ cc_library(
         "@platforms//os:none": [],
         "//conditions:default": ["_PW_MBEDTLS_IS_HOST=1"],
     }),
-    includes = ["."],
+    strip_include_prefix = ".",
 )
diff --git a/third_party/smartfusion_mss/BUILD.bazel b/third_party/smartfusion_mss/BUILD.bazel
@@ -27,7 +27,7 @@ liberosoc_configs = [
             "configs/config_pigweed_common.h",
         ],
         copts = ["-Dmss_CONFIG_FILE=\"%s\"" % config_header],
-        includes = ["."],
+        strip_include_prefix = ".",
     )
     for config_name, config_header in liberosoc_configs
 ]