Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/graph: Escape labels to support double quotes #689

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Commits on Mar 15, 2022

  1. internal/graph: Escape labels to support double quotes

    Fixes syntax errors when trying to render pprof profiles that have
    double quotes in tags. These can be created with Go's pprof labels
    feature, for example with:
    
    Fixes syntax errors when trying to render pprof profiles that have
    double quotes in tags. These can be created with Go's pprof labels
    feature, for example with:
    
    pprof.Labels("key", "label \"double quote\"\nline two")
    
    Trying to display a graph generated with this lable will fail:
    
    Error: <stdin>: syntax error in line 5 near 'quote'
    
    The double quote (") was never escaped in the label strings. Add
    a new escaping function that replaces newlines with centered lines
    (\n) because the existing one replaces newline with left-justified
    lines (\l).
    evanj committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    48de501 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2022

  1. Configuration menu
    Copy the full SHA
    34b8741 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. Configuration menu
    Copy the full SHA
    963a80d View commit details
    Browse the repository at this point in the history