Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add decorator to parse function type hints #350

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

keanpantraw
Copy link

@keanpantraw keanpantraw commented Aug 19, 2021

This allows to tell fire what types are expected by type hints (fixes #300, also see #327 and #260 ) and not change current behaviour by making it optional decorator.

@google-cla
Copy link

google-cla bot commented Aug 19, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to determine that you authored the commits in this PR. Maybe you used a different email address in the git commits than was used to sign the CLA? If someone else authored these commits, then please add them to this pull request and have them confirm that they're okay with them being contributed to Google. If there are co-authors, make sure they're formatted properly.

In order to pass this check, please resolve this problem and then comment@googlebot I fixed it... If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no Author has not signed CLA label Aug 19, 2021
@google-cla google-cla bot added cla: yes Author has signed CLA and removed cla: no Author has not signed CLA labels Aug 19, 2021
@keanpantraw keanpantraw force-pushed the master branch 5 times, most recently from f9bbc12 to 3f1cbb1 Compare August 21, 2021 14:50
@keanpantraw
Copy link
Author

@googlebot I fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Author has signed CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] typed arguments
1 participant