-
Notifications
You must be signed in to change notification settings - Fork 17
Add new equalisers, stream_types, play_ctrl_states #10
base: master
Are you sure you want to change the base?
Conversation
By using LG SP8YA (2021): - discovered new `equalisers`: "AI Sound Pro", "Clear Voice", "Sports", "Game" - added `stream_types`: "Google Cast", "Spotify Connect" - added `play_control_states` for streaming: "Playing", "Stopped/Paused"
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
@mjg59 Hi, sorry to disturb you. Without this pr new modals broke in Home Assistant so can you kindly consider review it and make a new release? Thanks a lot. |
Hey, friendly reminder for this pr. |
would love to see this get merge in soon |
@dunaparty can you add a new function ("E-ARC") so we can get this merged together (here is my tested patch)? |
Done. |
@bernimoses is anything else blocking this PR from going in? can you approve the PR and mearge it? |
Sorry i am not the maintainer. I think @mjg59 could merge it. |
@bernimoses will you consider the fork this library and merge pr and then add new library to Home Assistant as a dependency? |
@akinomeroglu if you get a fork up on pypi.org, i can update the home assistant Integration to use that as the dependency, it looks like this libary is not active |
Sorry i'm not much into python and i don't think that i can do a good job of maintaining this library. |
@dunaparty i have been in contact with @mjg59, he no longer has access to approve this PR but is working getting access or this PR approved |
FYI: temescal was updated and is now located at this link, this PR was added as part of this, https://github.com/mjg59/python-temescal HA was updated to use the new version along with some other updates |
By using LG SP8YA (2021):
equalisers
: "AI Sound Pro", "Clear Voice", "Sports", "Game"stream_types
: "Google Cast", "Spotify Connect"play_control_states
for streaming: "Playing", "Stopped/Paused"Fixes #9