Skip to content
This repository has been archived by the owner on May 28, 2024. It is now read-only.

Add new equalisers, stream_types, play_ctrl_states #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dunaparty
Copy link

By using LG SP8YA (2021):

  • discovered new equalisers: "AI Sound Pro", "Clear Voice", "Sports", "Game"
  • added stream_types: "Google Cast", "Spotify Connect"
  • added play_control_states for streaming: "Playing", "Stopped/Paused"

Fixes #9

By using LG SP8YA (2021):
- discovered new `equalisers`: "AI Sound Pro", "Clear Voice", "Sports", "Game"
- added `stream_types`: "Google Cast", "Spotify Connect"
- added `play_control_states` for streaming: "Playing", "Stopped/Paused"
@google-cla
Copy link

google-cla bot commented Sep 11, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@dunaparty
Copy link
Author

@googlebot I signed it!

@akinomeroglu
Copy link

@mjg59 Hi, sorry to disturb you. Without this pr new modals broke in Home Assistant so can you kindly consider review it and make a new release?

Thanks a lot.

@Syndlex
Copy link

Syndlex commented Jan 4, 2022

Hey, friendly reminder for this pr.

@MasonCrawford
Copy link

MasonCrawford commented Apr 18, 2022

would love to see this get merge in soon
@mjg59

@bernimoses
Copy link
Contributor

@dunaparty can you add a new function ("E-ARC") so we can get this merged together (here is my tested patch)?

@dunaparty
Copy link
Author

@dunaparty can you add a new function ("E-ARC") so we can get this merged together (here is my tested patch)?

Done.

@MasonCrawford
Copy link

@bernimoses is anything else blocking this PR from going in? can you approve the PR and mearge it?

@bernimoses
Copy link
Contributor

@bernimoses is anything else blocking this PR from going in? can you approve the PR and mearge it?

Sorry i am not the maintainer. I think @mjg59 could merge it.

@akinomeroglu
Copy link

@bernimoses will you consider the fork this library and merge pr and then add new library to Home Assistant as a dependency?

@MasonCrawford
Copy link

@akinomeroglu if you get a fork up on pypi.org, i can update the home assistant Integration to use that as the dependency, it looks like this libary is not active

@bernimoses
Copy link
Contributor

@bernimoses will you consider the fork this library and merge pr and then add new library to Home Assistant as a dependency?

Sorry i'm not much into python and i don't think that i can do a good job of maintaining this library.

@MasonCrawford
Copy link

@dunaparty i have been in contact with @mjg59, he no longer has access to approve this PR but is working getting access or this PR approved

@MasonCrawford
Copy link

FYI: temescal was updated and is now located at this link, this PR was added as part of this, https://github.com/mjg59/python-temescal

HA was updated to use the new version along with some other updates

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update for new SoundBar LG 2020
5 participants