Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate nonsemantic shader debug information #1392

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tksuoran
Copy link

Proof of concept fix for #1391.

Possibly emitNonSemanticShaderDebugInfo and emitNonSemanticShaderDebugSource should be controlled using dedicated command line arguments instead of just -g.

This worked for me and allowed me to use RenderDoc source debugging.

@vinh-truong-sc
Copy link

Hey, we are also interested in this feature. Can someone look at this and merge it?

Copy link
Collaborator

@dneto0 dneto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is good.
The policy question is that when using -g the downstream tools and driver have to undertand non-semantic extended instruction sets. So in theory it's a backward incompatibility. But this is about debug info and it's being used in a development environment so it has to be deliberately turned on, and the remedy is easy: turn it back off.

So I think this is the right thing to do, even with the theoretical incompatibility.

@dneto0 dneto0 enabled auto-merge (squash) April 10, 2024 14:14
@PolarNick239
Copy link

Hi! Debug information is very useful for Vulkan-API debugging with RenderDoc. I hope it will be merged soon! :)

@Trider12
Copy link

Why hasn't this been merged?

@dj2
Copy link
Contributor

dj2 commented Jul 11, 2024

There are failing tests which need to be fixed up. The glslc_tests, and a bunch of the shaderc test suites all failed with the patch applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants