-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/8418 Remove KMW redundant VRT Scenarios #9479
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…site-kit-wp into enhancement/8418-remove-KMW-VRTs.
Build files for 8be9cdc have been deleted. |
Size Change: 0 B Total Size: 1.83 MB ℹ️ View Unchanged
|
tofumatt
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
MetricTileNumeric
component.MetricTile___
components as they all "differ" slightly.As per my conversation with @tofumatt, all other scenarios have been deleted. A follow up issue, #9479 has been created to convert logic within all of these scenarios into Jest tests if necessary. We need to define properly which tests are needed and how to create reusable utility methods that can be used to set up the above states for each tile.
All old VRT reference images not being tested anymore have been pruned.
The
delay
property of 250ms has not been removed for now as this property over rides the default 1 sec delay set for all tests. This could cause the tests to take longer to run. However, testing this is time consuming and can be done in another issue.PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist