Enhancement/9377 Enable Dashboard Sharing for ACR tiles #9500
+15
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmymadon
changed the title
|
Build files for 52da7fa are ready:
|
|
Note for CR / MR: VRT and E2E test failures here are unrelated to this PR and are known issues. |
|
Size Change: +29 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
…sSettings() via shouldDisplayWidgetWithConversionEvent().
techanvil
reviewed
Oct 23, 2024
| @@ -476,8 +478,14 @@ const baseSelectors = { | |||
| return false; | |||
| } | |||
|
|
|||
| if ( widget.displayInList ) { | |||
| return widget.displayInList( select, isViewOnly ); | |||
| if ( | |||
There was a problem hiding this comment.
Hey @jimmymadon, I just want to flag my comment in Slack about this fix not working for the "Most popular products" tile's case, so it doesn't get overlooked.
Cc @tofumatt
There was a problem hiding this comment.
Ah thanks for flagging this @techanvil. I thought I tested this by selecting that tile but it only renders when there is a product post type. I will add this to #9548 and make this issue a P0 bug and reproduce it there. So then I can get some ACs and an IB for it soon and fix it properly rather than issue another quick fix here. It seems that no one has surprisingly complained as yet - so not many people might be using this tile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist