Add GA event tracking for the "Top content" metric area of an Audience Tile #9542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…"Top content" metric.
…rror` GA events for the "Top content" metric.
…multiple times within the set of Audience Tiles. This should be addressed in a more correct manner in a future issue.
…_access` and `setup_error_retry` GA events for the "Top content" metric.
…` and `setup_error_cancel` GA events for the "Top content" metric.
…ow for custom dimension creation. This ensures the custom dimension creation is auto-continued.
|
Build files for 78747fb are ready:
|
|
Size Change: +3.38 kB (+0.18%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
techanvil
commented
Oct 21, 2024
| @@ -77,6 +83,7 @@ export default function AudienceTilePagesMetric( { | |||
|
|
|||
| const redirectURL = addQueryArgs( global.location.href, { | |||
| notification: 'audience_segmentation', | |||
| widgetArea: AREA_MAIN_DASHBOARD_TRAFFIC_AUDIENCE_SEGMENTATION, | |||
There was a problem hiding this comment.
This fixes a bug I noticed where the custom dimension creation wasn't auto-continued when returning to Site Kit from the OAuth flow if the Audiences Widget Area isn't currently in view. The fix is to scroll to the widget area upon returning to the dashboard, as we do for the error case (see errorRedirectURL below).
techanvil
commented
Oct 21, 2024
| ).toBeInTheDocument(); | ||
| } ); | ||
|
|
||
| it( 'should track an event when the Retry button is clicked', async () => { |
There was a problem hiding this comment.
I didn't include tests for the auth_error, insufficient_permissions_error and setup_error events, see Relevant technical choices for the reason behind this.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
I didn't include tests for the
auth_error,insufficient_permissions_errorandsetup_errorGA events, due to difficulties getting theDialogcomponent'sonOpencallback to run, it's wrapped inrequestAnimationFrame(), and even when mockingrequestAnimationFrame()to invoke its callback, I ran into problems withFocusTrap. It didn't seem worth pushing the issue over the estimate in order to pursue the coverage for these events.For reference see:
onOpenis invoked bythis.adapter_.notifyOpened()PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist